Skip to content

Why v4-core is not installed as a direct dependency? #447

@gabkov

Description

@gabkov

Right now v4-core imports are resolved as transitive dependencies through v4-periphery.

For the compiler this is not an issue (FOUNDRY_AUTO_DETECT_REMAPPINGS is set to true by default, so I suppose VFS will have the v4-core deps ready by the time it needs it), however for example vscode extensions are fail to detect it even with direct remappings. I'm not sure if this was intentional or not just wanted to note it, since solmate is installed directly as well, but that could be pulled through permit2 similarly how v4-core is used currently.

Are there any particular reason why v4-core is not installed directly?

Thank you in advance

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions