Skip to content

[Bug]: Default forge install tags have conflicts between core and periphery #971

Open
@jaderiverstokes

Description

@jaderiverstokes

Describe the bug

v4-core has a tag at v4.0.0, and v4-periphery has no tags. So by default forge install will pull v4.0.0 for core and main for periphery. This will cause a build error from this new structs file which is present on main for periphery but missing from v4.0.0 on core.

Let's make a stable tag on v4-periphery to resolve this build error?

Expected Behavior

This should compile:

forge install uniswap/v4-core
forge install uniswap/v4-periphery
forge build

To Reproduce

forge install uniswap/v4-core
forge install uniswap/v4-periphery
forge build

2025-05-05T17:59:50.801291Z ERROR foundry_compilers_artifacts_solc::sources: error="/home/runner/work/Subscription-Contracts/Subscription-Contracts/lib/v4-core/src/types/PoolOperation.sol": No such file or directory (os error 2)
Error: failed to resolve file: "/home/runner/work/Subscription-Contracts/Subscription-Contracts/lib/v4-core/src/types/PoolOperation.sol": No such file or directory (os error 2); check configured remappings
--> /home/runner/work/Subscription-Contracts/Subscription-Contracts/lib/v4-periphery/src/PositionManager.sol
@uniswap/v4-core/src/types/PoolOperation.sol

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions