fix: propagate variant needs for refs with fragments

Author: damaz91

preprocess_schemas.py

@@ -597,8 +597,9 @@ def extract_external_refs(schema, path):
         for node in iter_nodes(data):
             if isinstance(node, dict) and "$ref" in node:
                 ref = node["$ref"]
-                if "#" not in ref:
-                    abs_path = str((path.parent / ref).resolve())
+                ref_file, _, _ = ref.partition("#")
+                if ref_file:
+                    abs_path = str((path.parent / ref_file).resolve())
                     refs.append((name, abs_path))
     return refs
 

tests/test_codegen_pipeline.py

@@ -591,6 +591,93 @@ def test_main_preprocesses_schema_tree_end_to_end(self) -> None:
         self.assertEqual(set(parent_variant["required"]), {"id", "child"})
         self.assertEqual(child_variant["required"], ["value"])
 
+    def test_propagation_with_fragment(self) -> None:
+        """Propagation should work even if the reference has a fragment."""
+        with tempfile.TemporaryDirectory() as temp_dir:
+            root = Path(temp_dir)
+            preprocess_schemas.save_json(
+                {
+                    "$defs": {
+                        "entity": {
+                            "type": "object",
+                            "properties": {"id": {"type": "string"}},
+                            "required": ["id"],
+                        }
+                    }
+                },
+                root / "ucp.json",
+            )
+            preprocess_schemas.save_json(
+                {
+                    "$id": "https://ucp.dev/schemas/child.json",
+                    "title": "Child",
+                    "type": "object",
+                    "$defs": {
+                        "item": {
+                            "type": "object",
+                            "properties": {
+                                "grandchild": {
+                                    "$ref": "grandchild.json"
+                                }
+                            }
+                        }
+                    },
+                    "properties": {
+                        "dummy": {"type": "string"}
+                    }
+                },
+                root / "child.json",
+            )
+            preprocess_schemas.save_json(
+                {
+                    "$id": "https://ucp.dev/schemas/grandchild.json",
+                    "title": "Grandchild",
+                    "type": "object",
+                    "properties": {
+                        "value": {
+                            "type": "string",
+                            "ucp_request": {"create": "required"},
+                        }
+                    },
+                },
+                root / "grandchild.json",
+            )
+            preprocess_schemas.save_json(
+                {
+                    "$id": "https://ucp.dev/schemas/parent.json",
+                    "title": "Parent",
+                    "allOf": [{"$ref": "ucp.json#/$defs/entity"}],
+                    "properties": {
+                        "child_item": {
+                            "$ref": "child.json#/$defs/item",
+                            "ucp_request": {"create": "required"},
+                        }
+                    },
+                },
+                root / "parent.json",
+            )
+
+            with (
+                mock.patch.object(
+                    sys,
+                    "argv",
+                    ["preprocess_schemas.py", str(root)],
+                ),
+                contextlib.redirect_stdout(io.StringIO()),
+            ):
+                preprocess_schemas.main()
+
+            self.assertTrue((root / "child_create_request.json").exists(), "child_create_request.json was not generated")
+            self.assertTrue((root / "grandchild_create_request.json").exists(), "grandchild_create_request.json was not generated")
+            
+            parent_variant = preprocess_schemas.load_json(
+                root / "parent_create_request.json"
+            )
+            self.assertEqual(
+                parent_variant["properties"]["child_item"]["$ref"],
+                "child_create_request.json#/$defs/item",
+            )
+
 
 class MetadataUnionTest(unittest.TestCase):
     """The UcpMetadata root union is derived from ucp.json $defs."""