Skip to content

Commit ee3a15c

Browse files
authored
chore: update governance to use workflow_run for review events (#50)
* chore: update governance to use workflow_run for review events This avoids missing secret issues when running governance checks on PRs from forks. * chore: pass pr-number and commit-sha to reusable governance workflow * chore: update governance workflow to let central repo resolve PR number from SHA
1 parent 298c295 commit ee3a15c

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

.github/workflows/governance.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,23 @@ on:
1313
assigned,
1414
unassigned
1515
]
16-
pull_request_review:
17-
types: [submitted, dismissed]
16+
workflow_run:
17+
workflows: ["PR Review Listener"]
18+
types: [completed]
1819

1920
jobs:
2021
governance:
2122
name: Reviews
22-
# skip for draft PRs
23-
if: github.event.pull_request.draft == false
2423
permissions:
2524
statuses: write
2625
contents: read
2726
pull-requests: read
2827
# Use the reusable workflow defined in the central governance repository
2928
# zizmor: ignore[ref-confusion]
3029
uses: Universal-Commerce-Protocol/.github/.github/workflows/reusable-governance.yml@main
30+
with:
31+
pr-number: ${{ github.event.pull_request.number }}
32+
commit-sha: ${{ github.event.pull_request.head.sha || github.event.workflow_run.head_sha }}
3133
secrets:
3234
# Required: An org-level Read token to read team memberships
3335
ORG_READ_TOKEN: ${{ secrets.ORG_READ_TOKEN }}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
name: PR Review Listener
2+
on:
3+
pull_request_review:
4+
types: [submitted, dismissed]
5+
6+
jobs:
7+
signal:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- name: Signal success
11+
run: |
12+
echo "PR ${{ github.event.pull_request.number }} review state changed."

0 commit comments

Comments
 (0)