Skip to content

Sus naming of podcast endpoint (session.Get) #66

@MattWindsor91

Description

@MattWindsor91

This method, in podcast.go, is presumably supposed to be named something like GetPodcast (or be Get on a podcast related type), but is instead named session.Get:

myradio-go/podcast.go

Lines 23 to 28 in 6858956

// Get retrieves the data for a single podcast from MyRadio given it's ID.
// This consumes one API request.
func (s *Session) Get(id int) (podcast *Podcast, err error) {
err = s.getf("/podcast/%d", id).Into(&podcast)
return
}

That name is ambiguous and also might theoretically clash with any other model that can be got using a Session. Can we rename this, or do things upstream now depend on this name?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions