Unify delete tools (#48)

Author: plutasnyy

.github/workflows/release.yml

@@ -36,6 +36,7 @@ jobs:
       - name: Get version from main
         id: get-main-version
         run: |
+          source .venv/bin/activate
           git switch main
           MAIN_VERSION=$(python -c "import toml; print(toml.load('pyproject.toml')['project']['version'])")
           echo "MAIN_VERSION=$MAIN_VERSION" >> $GITHUB_ENV
@@ -44,6 +45,7 @@ jobs:
       - name: Compare versions
         id: compare-versions
         run: |
+          source .venv/bin/activate
           CUR_VERSION=$(python -c "import toml; print(toml.load('pyproject.toml')['project']['version'])")
 
           echo "Current version in pyproject.toml: $CUR_VERSION"
@@ -55,6 +57,7 @@ jobs:
           else
             echo "Versions differ. Proceed with the release."
             echo "SKIP_RELEASE=false" >> $GITHUB_ENV
+          fi
 
       - name: Release to PyPI
         if: env.SKIP_RELEASE != 'true'

CHANGELOG.md

@@ -3,6 +3,7 @@
 ### Enhancements
 
 - Duplicated description of the custom workflow was removed from the tools, freeing up tokens from the LLM.
+- **Delete Connector Tools Unification**: All delete tools require just the ID of the connector, so they were combined into one tool for sources and one for destinations.
 
 ### Fixes
 

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "uns_mcp"
-version = "0.1.2.2" # Set only non-dev versions to release. Setting extra .2 as 0.1.2 was already released and the name if locked forever. During next release point to 0.1.3
+version = "0.1.2.3" # Set only non-dev versions to release. Setting extra .2 as 0.1.2 was already released and the name if locked forever. During next release point to 0.1.3
 description = "MCP server implementation providing structured tools for interacting with the Unstructured API, managing sources, destinations, workflows, and jobs"
 requires-python = ">=3.12"
 readme = "README.md"

uns_mcp/connectors/destination/__init__.py

@@ -3,80 +3,54 @@
 
 def register_destination_connectors(mcp: FastMCP):
     """Register all destination connector tools with the MCP server."""
-    from .astra import (
-        create_astradb_destination,
-        delete_astradb_destination,
-        update_astradb_destination,
+    from connectors.destination.mongo import (
+        create_mongodb_destination,
+        update_mongodb_destination,
     )
+
+    from .astra import create_astradb_destination, update_astradb_destination
     from .databricks_vdt import (
         create_databricks_delta_table_destination,
-        delete_databricks_delta_table_destination,
         update_databricks_delta_table_destination,
     )
     from .databricksvolumes import (
         create_databricks_volumes_destination,
-        delete_databricks_volumes_destination,
         update_databricks_volumes_destination,
     )
-    from .mongo import (
-        create_mongodb_destination,
-        delete_mongodb_destination,
-        update_mongodb_destination,
-    )
-    from .neo4j import (
-        create_neo4j_destination,
-        delete_neo4j_destination,
-        update_neo4j_destination,
-    )
-    from .pinecone import (
-        create_pinecone_destination,
-        delete_pinecone_destination,
-        update_pinecone_destination,
-    )
-    from .s3 import create_s3_destination, delete_s3_destination, update_s3_destination
-    from .weaviate import (
-        create_weaviate_destination,
-        delete_weaviate_destination,
-        update_weaviate_destination,
-    )
+    from .neo4j import create_neo4j_destination, update_neo4j_destination
+    from .pinecone import create_pinecone_destination, update_pinecone_destination
+    from .s3 import create_s3_destination, update_s3_destination
+    from .weaviate import create_weaviate_destination, update_weaviate_destination
 
     # Register S3 destination connector tools
     mcp.tool()(create_s3_destination)
     mcp.tool()(update_s3_destination)
-    mcp.tool()(delete_s3_destination)
 
     # Register Weaviate destination connector tools
     mcp.tool()(create_weaviate_destination)
     mcp.tool()(update_weaviate_destination)
-    mcp.tool()(delete_weaviate_destination)
 
     # Register AstraDB destination connector tools
     mcp.tool()(create_astradb_destination)
     mcp.tool()(update_astradb_destination)
-    mcp.tool()(delete_astradb_destination)
 
     # Register Neo4j destination connector tools
     mcp.tool()(create_neo4j_destination)
     mcp.tool()(update_neo4j_destination)
-    mcp.tool()(delete_neo4j_destination)
 
     # Register MongoDB destination connector tools
     mcp.tool()(create_mongodb_destination)
     mcp.tool()(update_mongodb_destination)
-    mcp.tool()(delete_mongodb_destination)
 
     # Register databricks destination connector tools
     mcp.tool()(create_databricks_volumes_destination)
     mcp.tool()(update_databricks_volumes_destination)
-    mcp.tool()(delete_databricks_volumes_destination)
 
     # Register databricks delta table destination connector tools
     mcp.tool()(create_databricks_delta_table_destination)
     mcp.tool()(update_databricks_delta_table_destination)
-    mcp.tool()(delete_databricks_delta_table_destination)
 
     # Register Pinecone destination connector tools
 
     mcp.tool()(create_pinecone_destination)
     mcp.tool()(update_pinecone_destination)
-    mcp.tool()(delete_pinecone_destination)

uns_mcp/connectors/destination/astra.py

@@ -5,7 +5,6 @@
 from mcp.server.fastmcp import Context
 from unstructured_client.models.operations import (
     CreateDestinationRequest,
-    DeleteDestinationRequest,
     GetDestinationRequest,
     UpdateDestinationRequest,
 )
@@ -188,23 +187,3 @@ async def update_astradb_destination(
         return result
     except Exception as e:
         return f"Error updating AstraDB destination connector: {str(e)}"
-
-
-async def delete_astradb_destination(ctx: Context, destination_id: str) -> str:
-    """Delete an AstraDB destination connector.
-
-    Args:
-        destination_id: ID of the destination connector to delete
-
-    Returns:
-        String containing the result of the deletion
-    """
-    client = ctx.request_context.lifespan_context.client
-
-    try:
-        _ = await client.destinations.delete_destination_async(
-            request=DeleteDestinationRequest(destination_id=destination_id),
-        )
-        return f"AstraDB Destination Connector with ID {destination_id} deleted successfully"
-    except Exception as e:
-        return f"Error deleting AstraDB destination connector: {str(e)}"

uns_mcp/connectors/destination/databricks_vdt.py

@@ -4,7 +4,6 @@
 from mcp.server.fastmcp import Context
 from unstructured_client.models.operations import (
     CreateDestinationRequest,
-    DeleteDestinationRequest,
     GetDestinationRequest,
     UpdateDestinationRequest,
 )
@@ -195,24 +194,3 @@ async def update_databricks_delta_table_destination(
         return result
     except Exception as e:
         return f"Error updating databricks volumes Delta Table destination connector: {str(e)}"
-
-
-async def delete_databricks_delta_table_destination(ctx: Context, destination_id: str) -> str:
-    """Delete an databricks volumes destination connector.
-
-    Args:
-        destination_id: ID of the destination connector to delete
-
-    Returns:
-        String containing the result of the deletion
-    """
-    client = ctx.request_context.lifespan_context.client
-
-    try:
-        _ = await client.destinations.delete_destination_async(
-            request=DeleteDestinationRequest(destination_id=destination_id),
-        )
-        return f"Databricks volumes Delta Table Destination Connector with ID {destination_id} \
-            deleted successfully"
-    except Exception as e:
-        return f"Error deleting Databricks volumes Delta Table destination connector: {str(e)}"

uns_mcp/connectors/destination/databricksvolumes.py

@@ -4,7 +4,6 @@
 from mcp.server.fastmcp import Context
 from unstructured_client.models.operations import (
     CreateDestinationRequest,
-    DeleteDestinationRequest,
     GetDestinationRequest,
     UpdateDestinationRequest,
 )
@@ -165,24 +164,3 @@ async def update_databricks_volumes_destination(
         return result
     except Exception as e:
         return f"Error updating databricks volumes destination connector: {str(e)}"
-
-
-async def delete_databricks_volumes_destination(ctx: Context, destination_id: str) -> str:
-    """Delete an databricks volumes destination connector.
-
-    Args:
-        destination_id: ID of the destination connector to delete
-
-    Returns:
-        String containing the result of the deletion
-    """
-    client = ctx.request_context.lifespan_context.client
-
-    try:
-        _ = await client.destinations.delete_destination_async(
-            request=DeleteDestinationRequest(destination_id=destination_id),
-        )
-        return f"Databricks volumes Destination Connector with ID {destination_id} \
-            deleted successfully"
-    except Exception as e:
-        return f"Error deleting Databricks volumes destination connector: {str(e)}"

uns_mcp/connectors/destination/generic.py

@@ -0,0 +1,22 @@
+from mcp.server.fastmcp import Context
+from unstructured_client.models.operations import DeleteDestinationRequest
+
+
+async def delete_destination(ctx: Context, destination_id: str) -> str:
+    """Delete a destination connector.
+
+    Args:
+        destination_id: ID of the destination connector to delete
+
+    Returns:
+        String containing the result of the deletion
+    """
+    client = ctx.request_context.lifespan_context.client
+
+    try:
+        _ = await client.destinations.delete_destination_async(
+            request=DeleteDestinationRequest(destination_id=destination_id),
+        )
+        return f"Destination Connector with ID {destination_id} deleted successfully"
+    except Exception as e:
+        return f"Error deleting destination connector: {str(e)}"

uns_mcp/connectors/destination/mongo.py

@@ -4,7 +4,6 @@
 from mcp.server.fastmcp import Context
 from unstructured_client.models.operations import (
     CreateDestinationRequest,
-    DeleteDestinationRequest,
     GetDestinationRequest,
     UpdateDestinationRequest,
 )
@@ -126,23 +125,3 @@ async def update_mongodb_destination(
         return result
     except Exception as e:
         return f"Error updating MongoDB destination connector: {str(e)}"
-
-
-async def delete_mongodb_destination(ctx: Context, destination_id: str) -> str:
-    """Delete an MongoDB destination connector.
-
-    Args:
-        destination_id: ID of the destination connector to delete
-
-    Returns:
-        String containing the result of the deletion
-    """
-    client = ctx.request_context.lifespan_context.client
-
-    try:
-        _ = await client.destinations.delete_destination_async(
-            request=DeleteDestinationRequest(destination_id=destination_id),
-        )
-        return f"MongoDB Destination Connector with ID {destination_id} deleted successfully"
-    except Exception as e:
-        return f"Error deleting MongoDB destination connector: {str(e)}"

uns_mcp/connectors/destination/neo4j.py

@@ -4,7 +4,6 @@
 from mcp.server.fastmcp import Context
 from unstructured_client.models.operations import (
     CreateDestinationRequest,
-    DeleteDestinationRequest,
     GetDestinationRequest,
     UpdateDestinationRequest,
 )
@@ -138,23 +137,3 @@ async def update_neo4j_destination(
         return result
     except Exception as e:
         return f"Error updating neo4j destination connector: {str(e)}"
-
-
-async def delete_neo4j_destination(ctx: Context, destination_id: str) -> str:
-    """Delete an neo4j destination connector.
-
-    Args:
-        destination_id: ID of the destination connector to delete
-
-    Returns:
-        String containing the result of the deletion
-    """
-    client = ctx.request_context.lifespan_context.client
-
-    try:
-        _ = await client.destinations.delete_destination_async(
-            request=DeleteDestinationRequest(destination_id=destination_id),
-        )
-        return f"neo4j Destination Connector with ID {destination_id} deleted successfully"
-    except Exception as e:
-        return f"Error deleting neo4j destination connector: {str(e)}"