Skip to content

Commit a673535

Browse files
authored
bugfix/make sharepoint permission configs optional (#129)
* Make all permission configs optional with a default of None * Add changelog entry * update changelog
1 parent 180c55d commit a673535

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
## 0.0.15-dev4
1+
## 0.0.15
22

33
### Fixes
44

55
* **Model serialization with nested models** Logic updated to properly handle serializing pydantic models that have nested configs with secret values.
66
* **Sharepoint permission config requirement** The sharepoint connector was expecting the permission config, even though it should have been optional.
7+
* **Sharepoint CLI permission params made optional
78

89
### Enhancements
910

unstructured_ingest/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.0.15-dev4" # pragma: no cover
1+
__version__ = "0.0.15" # pragma: no cover

unstructured_ingest/v2/processes/connectors/sharepoint.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,16 @@ class SharepointAccessConfig(AccessConfig):
6060

6161

6262
class SharepointPermissionsConfig(BaseModel):
63-
permissions_application_id: str = Field(description="Microsoft Graph API application id")
64-
permissions_tenant: str = Field(
63+
permissions_application_id: Optional[str] = Field(
64+
default=None, description="Microsoft Graph API application id"
65+
)
66+
permissions_tenant: Optional[str] = Field(
67+
default=None,
6568
description="url to get permissions data within tenant.",
6669
examples=["https://contoso.onmicrosoft.com"],
6770
)
68-
permissions_client_cred: SecretStr = Field(
69-
description="Microsoft Graph API application credentials"
71+
permissions_client_cred: Optional[SecretStr] = Field(
72+
default=None, description="Microsoft Graph API application credentials"
7073
)
7174
authority_url: Optional[SecretStr] = Field(
7275
repr=False,

0 commit comments

Comments
 (0)