-
Notifications
You must be signed in to change notification settings - Fork 3
Remove unstructured-ingest as a dependency #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ] | ||
|
|
||
| [[package]] | ||
| name = "unstructured-ingest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adios friend
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
| class EtlApiException(Exception): | ||
| pass | ||
|
|
||
| def file_data_from_dict(data: dict) -> FileDataType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i'll just move this into utic_public_types instead.
| return BatchFileData.model_validate(data) | ||
| except ValidationError: | ||
| logger.debug(f"{data} not valid for batch file data") | ||
| return FileData.model_validate(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might also need try-return approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have explained this better. I'm gonna remove this from here and just move it into the utic-public-types in file_data where it really belongs. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats why i made the other PR.
Note
Replaces unstructured-ingest with utic-public-types, updates imports and error types, adds local file_data_from_dict using Pydantic, and bumps version to 0.0.42.
unstructured_ingesttypes/errors withutic_public_typesinetl_uvicorn/api_generator.pyand related modules.file_data_from_dict(PydanticValidationError-based) to parseFileData/BatchFileData.file_data,errors) toutic_public_types.unstructured-ingestdependency; addutic-public-typesinpyproject.toml.0.0.42; add changelog entry for dependency removal.Written by Cursor Bugbot for commit 3320a22. This will update automatically on new commits. Configure here.