Skip to content

Commit bdfcc14

Browse files
fix: fix partition_via_api retry mechanism when the default SDK's retry config is empty. (#3746)
1 parent 0b4c72a commit bdfcc14

File tree

4 files changed

+32
-2
lines changed

4 files changed

+32
-2
lines changed

Diff for: CHANGELOG.md

+10
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## 0.16.2-dev1
2+
3+
### Enhancements
4+
5+
### Features
6+
7+
### Fixes
8+
9+
## **Fixed retry config settings for partition_via_api function** If the SDK's default retry config is not set the retry config getter function does not fail anymore.
10+
111
## 0.16.1
212

313
### Enhancements

Diff for: test_unstructured/partition/test_api.py

+19
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,25 @@ def test_retries_config_none_parameters_return_empty_config():
246246
assert retries_config is None
247247

248248

249+
def test_retry_config_with_empty_sdk_retry_config_returns_default():
250+
sdk = Mock()
251+
sdk.sdk_configuration.retry_config = None
252+
retries_config = get_retries_config(
253+
retries_connection_errors=True,
254+
retries_exponent=1.88,
255+
retries_initial_interval=3000,
256+
retries_max_elapsed_time=None,
257+
retries_max_interval=None,
258+
sdk=sdk,
259+
)
260+
261+
assert retries_config.retry_connection_errors
262+
assert retries_config.backoff.exponent == 1.88
263+
assert retries_config.backoff.initial_interval == 3000
264+
assert retries_config.backoff.max_elapsed_time == DEFAULT_RETRIES_MAX_ELAPSED_TIME_SEC
265+
assert retries_config.backoff.max_interval == DEFAULT_RETRIES_MAX_INTERVAL_SEC
266+
267+
249268
def test_retries_config_with_no_parameters_set():
250269
retry_config = retries.RetryConfig(
251270
"backoff", retries.BackoffStrategy(3000, 720000, 1.88, 1800000), True

Diff for: unstructured/__version__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.16.1" # pragma: no cover
1+
__version__ = "0.16.2-dev1" # pragma: no cover

Diff for: unstructured/partition/api.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,8 @@ def get_backoff_default(setting_name: str, default_value: Any) -> Any:
195195

196196
default_retries_connneciton_errors = (
197197
sdk_default_retries_config.retry_connection_errors
198-
if sdk_default_retries_config.retry_connection_errors is not None
198+
if sdk_default_retries_config
199+
and sdk_default_retries_config.retry_connection_errors is not None
199200
else DEFAULT_RETRIES_CONNECTION_ERRORS
200201
)
201202

0 commit comments

Comments
 (0)