Skip to content

Commit 0dbd512

Browse files
nhortonclaude
andauthored
Add types: [checks_requested] to merge_group triggers (#55)
GitHub documentation recommends explicitly specifying the activity type for merge_group triggers. This ensures proper workflow triggering in the merge queue and future-proofs against new activity types being added. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 1f9580f commit 0dbd512

4 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,14 @@ We use a skip pattern so the same required checks pass in both PR and merge queu
2626

2727
### How It Works
2828

29-
All workflows specify explicit branch targeting:
29+
All workflows specify explicit branch targeting and the `checks_requested` type:
3030

3131
```yaml
3232
on:
3333
pull_request:
3434
branches: [main]
3535
merge_group:
36+
types: [checks_requested]
3637
branches: [main]
3738
workflow_dispatch: # Enables manual triggering for testing
3839
```
@@ -71,7 +72,7 @@ In GitHub branch protection rules, require these checks:
7172

7273
All checks will pass in both PR and merge queue contexts (either by running or by being skipped).
7374

74-
**Note**: The explicit branch targeting in `merge_group` triggers is critical for workflows to run properly in the merge queue. Without this, GitHub may not trigger the workflows and they will remain in "expected" state.
75+
**Note**: The explicit `types: [checks_requested]` and branch targeting in `merge_group` triggers is critical for workflows to run properly in the merge queue. The `types` parameter is recommended by GitHub to future-proof against new activity types. Without proper configuration, GitHub may not trigger the workflows and they will remain in "expected" state.
7576

7677
## Workflow Details
7778

.github/workflows/cla.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
branches: [main]
99
# Run in merge queue but skip the step (shows as passing check)
1010
merge_group:
11+
types: [checks_requested]
1112
branches: [main]
1213
workflow_dispatch:
1314

.github/workflows/claude-code-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ on:
1414
branches: [main]
1515
# Run in the merge queue to validate before merging
1616
merge_group:
17+
types: [checks_requested]
1718
branches: [main]
1819

1920
# Ensure only one instance runs at a time per PR/branch

.github/workflows/validate.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
pull_request:
55
branches: [main]
66
merge_group:
7+
types: [checks_requested]
78
branches: [main]
89
workflow_dispatch:
910

0 commit comments

Comments
 (0)