Skip to content

Commit 113a5ee

Browse files
committed
Remove idempotency verification and unused output_mode config
- Don't enforce idempotency, just document it as expected behavior - Give lint formatters (black, ruff, prettier) as good examples - Remove output_mode from config (not referenced elsewhere) - Remove idempotency verification test scenarios
1 parent 5dfbd83 commit 113a5ee

3 files changed

Lines changed: 7 additions & 20 deletions

File tree

doc/policy_syntax.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,7 @@ action:
237237

238238
**Idempotency Requirement:**
239239

240-
Commands MUST be idempotent. The system verifies this by:
241-
1. Running the command
242-
2. Checking for changes
243-
3. If changes occurred, running again
244-
4. If more changes occur, marking as failed
240+
Commands should be idempotent—running them multiple times produces the same result. Lint formatters like `black`, `ruff format`, and `prettier` are good examples: they produce consistent output regardless of how many times they run.
245241

246242
## Pattern Syntax
247243

doc/policy_system_design.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ action:
7474
run_for: each_match
7575
```
7676
77-
Command actions execute idempotent commands. The system verifies idempotency by running the command twice and checking that no additional changes occur.
77+
Command actions should be idempotent—running them multiple times produces the same result. Lint formatters like `black`, `ruff format`, and `prettier` are good examples.
7878

7979
## Architecture
8080

@@ -471,7 +471,6 @@ In `.deepwork/config.yml`:
471471
policy:
472472
enabled: true
473473
policies_dir: .deepwork/policies # Can be customized
474-
output_mode: batched # batched or individual
475474
```
476475
477476
## Performance Considerations

doc/test_scenarios.md

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -199,22 +199,14 @@ action:
199199
| CMD-5.2.1 | Multiple files | `["a.js", "b.js", "c.js"]` | `eslint --fix a.js b.js c.js` |
200200
| CMD-5.2.2 | Single file | `["a.js"]` | `eslint --fix a.js` |
201201

202-
### 5.3 Idempotency Verification
203-
204-
| ID | Scenario | First Run | Second Run | Expected Result |
205-
|----|----------|-----------|------------|-----------------|
206-
| CMD-5.3.1 | Truly idempotent | Changes files | No changes | Pass |
207-
| CMD-5.3.2 | Not idempotent | Changes files | Changes files | Fail |
208-
| CMD-5.3.3 | No changes needed | No changes | (not run) | Pass |
209-
210-
### 5.4 Command Errors
202+
### 5.3 Command Errors
211203

212204
| ID | Scenario | Command Result | Expected |
213205
|----|----------|----------------|----------|
214-
| CMD-5.4.1 | Exit code 0 | Success | Pass |
215-
| CMD-5.4.2 | Exit code 1 | Failure | Fail, show stderr |
216-
| CMD-5.4.3 | Timeout | Command hangs | Fail, timeout error |
217-
| CMD-5.4.4 | Command not found | Not executable | Fail, not found error |
206+
| CMD-5.3.1 | Exit code 0 | Success | Pass |
207+
| CMD-5.3.2 | Exit code 1 | Failure | Fail, show stderr |
208+
| CMD-5.3.3 | Timeout | Command hangs | Fail, timeout error |
209+
| CMD-5.3.4 | Command not found | Not executable | Fail, not found error |
218210

219211
## 6. Queue System
220212

0 commit comments

Comments
 (0)