Commit 29a2959
chore: split Makefile lint target into lint (check) and lint-fix (auto-fix)
Previously `make lint` ran `ruff format` and `ruff check --fix` — both in
auto-fix mode — so it silently mutated files instead of reporting issues.
CI, on the other hand, runs `ruff format --check` and `ruff check` in
check-only mode, which is what actually fails a PR. That asymmetry meant a
clean local `make lint` gave no guarantee that CI would pass: running it
would just reformat files in-place, and the developer might miss the
uncommitted changes.
Splits into two targets:
- `make lint` now mirrors CI (ruff format --check, ruff check, mypy).
A clean run guarantees the CI Lint job will pass.
- `make lint-fix` is the previous behavior (auto-fix formatter + linter)
for convenient local cleanup.
Caught while working on #350 — my local `ruff check` calls did not run the
formatter at all, and even `make lint` would have only silently reformatted
the files, leaving a surprise CI failure.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent e5db75f commit 29a2959
1 file changed
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
1 | 7 | | |
2 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
3 | 15 | | |
4 | 16 | | |
5 | 17 | | |
0 commit comments