Skip to content

Commit 2d567d8

Browse files
nhortonclaude
andcommitted
fix: soften review-strategy-matches-criteria-scope wording
The previous wording forbade any cross-file reasoning from `strategy: individual`, which would disqualify legitimate cases like a Python code review rule where the reviewer may need to consult other project files (imports, references, related code, conventions) while evaluating a single changed file. Reworded so the distinction is about whether the reviewer needs to look at the OTHER CHANGED FILES in the same review set, not whether they need to look at any other file at all. Individual is appropriate when focus is heavily on each file and the reviewer is unlikely to need to see the other changed files; matches_together is for criteria that reason about the set as a whole (coverage, deduplication, consistency across the set). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent abff8bb commit 2d567d8

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

src/deepwork/standard_schemas/job_yml/deepschema.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,17 @@ requirements:
7777
outside their scope.
7878
7979
review-strategy-matches-criteria-scope: >
80-
A review `strategy: individual` MUST only be used when every listed criterion can be
81-
evaluated from a single file in isolation. Criteria that require cross-file comparison,
82-
project-wide enumeration, set-level properties (coverage, minimality, deduplication),
83-
or reasoning about the relationship between multiple output files MUST use
84-
`strategy: matches_together` so the reviewer sees the full set at once. Using
85-
`individual` with cross-cutting criteria forces each reviewer to redo the project-wide
86-
scan N times and multiplies latency without improving review quality.
80+
Choose the review `strategy` based on whether the criteria need to reason across the
81+
other changed files in the same review set. Use `individual` when the focus is
82+
heavily on each file itself and the reviewer is unlikely to need to look at the other
83+
changed files in order to evaluate this one — the reviewer MAY still consult unchanged
84+
project files for context (imports, references, related code, conventions), and that
85+
does not disqualify `individual`. Use `matches_together` when the changed files are
86+
likely to need to be looked at alongside each other during review — e.g., criteria
87+
about coverage across the set, deduplication, consistency between the files, or any
88+
property of the set as a whole. Picking `individual` for set-level criteria forces
89+
each spawned reviewer to redo the full cross-file scan N times and multiplies latency
90+
without improving review quality.
8791
8892
review-no-redundant-context: >
8993
Review `instructions` MUST NOT repeat domain context already in `common_job_info` since

0 commit comments

Comments
 (0)