Skip to content

Commit 4ff13c4

Browse files
nhortonclaude
andcommitted
fix: clarify mark_review_as_passed guidance for dismissed findings
The instruction file's "After Review" section now covers all three cases: no findings, findings fixed, or findings explicitly dismissed. The MCP tool description is updated to match. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3b863b1 commit 4ff13c4

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/deepwork/jobs/mcp/server.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,10 @@ async def get_configured_reviews(
490490
@mcp.tool(
491491
description=(
492492
"Mark a review as passed so it won't be re-run while reviewed files "
493-
"remain unchanged. The review_id is provided in the instruction file's "
494-
'"After Review" section.'
493+
"remain unchanged. Call this when a review has no findings, when all "
494+
"findings have been fixed, or when remaining findings have been "
495+
"explicitly dismissed by the user. The review_id is provided in the "
496+
'instruction file\'s "After Review" section.'
495497
)
496498
)
497499
async def mark_review_as_passed(review_id: str, ctx: Context) -> str:

src/deepwork/review/instructions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,8 @@ def build_instruction_file(
302302
if review_id:
303303
parts.append("## After Review\n")
304304
parts.append(
305-
"If this review passes with no findings, call the `mark_review_as_passed` tool with:\n"
305+
"If this review passes with no findings, or if all findings have been "
306+
"addressed or explicitly dismissed, call the `mark_review_as_passed` tool with:\n"
306307
)
307308
parts.append(f'- `review_id`: `"{review_id}"`')
308309
parts.append("")

0 commit comments

Comments
 (0)