|
| 1 | +"""Tests for rules_check hook module.""" |
| 2 | + |
| 3 | +from deepwork.hooks.rules_check import extract_promise_tags |
| 4 | + |
| 5 | + |
| 6 | +class TestExtractPromiseTags: |
| 7 | + """Tests for extract_promise_tags function.""" |
| 8 | + |
| 9 | + def test_extracts_simple_promise(self) -> None: |
| 10 | + """Test extracting a simple promise tag.""" |
| 11 | + text = "I've reviewed this. <promise>Rule Name</promise>" |
| 12 | + result = extract_promise_tags(text) |
| 13 | + assert result == {"Rule Name"} |
| 14 | + |
| 15 | + def test_extracts_promise_with_checkmark(self) -> None: |
| 16 | + """Test extracting promise tag with checkmark prefix.""" |
| 17 | + text = "Done. <promise>✓ Rule Name</promise>" |
| 18 | + result = extract_promise_tags(text) |
| 19 | + assert result == {"Rule Name"} |
| 20 | + |
| 21 | + def test_extracts_promise_with_checkmark_no_space(self) -> None: |
| 22 | + """Test extracting promise tag with checkmark but no space.""" |
| 23 | + text = "<promise>✓Rule Name</promise>" |
| 24 | + result = extract_promise_tags(text) |
| 25 | + assert result == {"Rule Name"} |
| 26 | + |
| 27 | + def test_extracts_multiple_promises(self) -> None: |
| 28 | + """Test extracting multiple promise tags.""" |
| 29 | + text = """ |
| 30 | + <promise>Rule One</promise> |
| 31 | + <promise>✓ Rule Two</promise> |
| 32 | + <promise>Rule Three</promise> |
| 33 | + """ |
| 34 | + result = extract_promise_tags(text) |
| 35 | + assert result == {"Rule One", "Rule Two", "Rule Three"} |
| 36 | + |
| 37 | + def test_case_insensitive_tag(self) -> None: |
| 38 | + """Test that promise tags are case-insensitive.""" |
| 39 | + text = "<PROMISE>Rule Name</PROMISE>" |
| 40 | + result = extract_promise_tags(text) |
| 41 | + assert result == {"Rule Name"} |
| 42 | + |
| 43 | + def test_preserves_rule_name_case(self) -> None: |
| 44 | + """Test that rule name case is preserved.""" |
| 45 | + text = "<promise>Architecture Documentation Accuracy</promise>" |
| 46 | + result = extract_promise_tags(text) |
| 47 | + assert result == {"Architecture Documentation Accuracy"} |
| 48 | + |
| 49 | + def test_handles_whitespace_in_tag(self) -> None: |
| 50 | + """Test handling of whitespace around rule name.""" |
| 51 | + text = "<promise> Rule Name </promise>" |
| 52 | + result = extract_promise_tags(text) |
| 53 | + assert result == {"Rule Name"} |
| 54 | + |
| 55 | + def test_handles_newlines_in_tag(self) -> None: |
| 56 | + """Test handling of newlines in promise tag.""" |
| 57 | + text = "<promise>\n Rule Name\n</promise>" |
| 58 | + result = extract_promise_tags(text) |
| 59 | + assert result == {"Rule Name"} |
| 60 | + |
| 61 | + def test_returns_empty_set_for_no_promises(self) -> None: |
| 62 | + """Test that empty set is returned when no promises exist.""" |
| 63 | + text = "No promises here." |
| 64 | + result = extract_promise_tags(text) |
| 65 | + assert result == set() |
| 66 | + |
| 67 | + def test_handles_empty_string(self) -> None: |
| 68 | + """Test handling of empty string.""" |
| 69 | + result = extract_promise_tags("") |
| 70 | + assert result == set() |
| 71 | + |
| 72 | + def test_real_world_command_error_promise(self) -> None: |
| 73 | + """Test promise format shown in command error output.""" |
| 74 | + # This is the exact format shown to agents when a command rule fails |
| 75 | + text = "<promise>✓ Manual Test: Infinite Block Command</promise>" |
| 76 | + result = extract_promise_tags(text) |
| 77 | + assert result == {"Manual Test: Infinite Block Command"} |
| 78 | + |
| 79 | + def test_mixed_formats_in_same_text(self) -> None: |
| 80 | + """Test extracting both checkmark and non-checkmark promises.""" |
| 81 | + text = """ |
| 82 | + <promise>Rule Without Checkmark</promise> |
| 83 | + <promise>✓ Rule With Checkmark</promise> |
| 84 | + """ |
| 85 | + result = extract_promise_tags(text) |
| 86 | + assert result == {"Rule Without Checkmark", "Rule With Checkmark"} |
| 87 | + |
| 88 | + def test_promise_with_special_characters_in_name(self) -> None: |
| 89 | + """Test promise with special characters in rule name.""" |
| 90 | + text = "<promise>Source/Test Pairing</promise>" |
| 91 | + result = extract_promise_tags(text) |
| 92 | + assert result == {"Source/Test Pairing"} |
| 93 | + |
| 94 | + def test_promise_embedded_in_markdown(self) -> None: |
| 95 | + """Test promise tag embedded in markdown text.""" |
| 96 | + text = """ |
| 97 | + I've reviewed the documentation and it's accurate. |
| 98 | +
|
| 99 | + <promise>Architecture Documentation Accuracy</promise> |
| 100 | + <promise>README Accuracy</promise> |
| 101 | +
|
| 102 | + The changes were purely cosmetic. |
| 103 | + """ |
| 104 | + result = extract_promise_tags(text) |
| 105 | + assert result == {"Architecture Documentation Accuracy", "README Accuracy"} |
0 commit comments