refactor: use yaml.safe_load unconditionally since YAML is a JSON superset

Simplifies the implementation — no need to branch on file extension.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: nhorton

specs/deepwork/jobs/JOBS-REQ-004-quality-review-system.md

@@ -15,7 +15,7 @@ The quality review system evaluates step outputs against defined quality criteri
 ### JOBS-REQ-004.2: JSON Schema Validation
 
 1. `validate_json_schemas()` MUST check all `file_path` type outputs that have a `json_schema` defined on their `StepArgument`.
-2. For each such output, the file content MUST be parsed and validated against the schema. Files with `.yml` or `.yaml` extensions MUST be parsed as YAML; all other files MUST be parsed as JSON.
+2. For each such output, the file content MUST be parsed as YAML (which is a superset of JSON) and validated against the schema.
 3. If file parsing fails, the error MUST be included in the returned error list.
 4. If schema validation fails, the error MUST be included in the returned error list.
 5. Files that do not exist MUST be skipped (not treated as errors by this function).

src/deepwork/jobs/mcp/quality_gate.py

@@ -7,7 +7,6 @@
 
 from __future__ import annotations
 
-import json
 import logging
 from pathlib import Path
 
@@ -59,18 +58,11 @@ def validate_json_schemas(
             if not full_path.exists():
                 continue
             try:
-                content = full_path.read_text(encoding="utf-8")
-                if full_path.suffix in (".yml", ".yaml"):
-                    import yaml
+                import yaml
 
-                    parsed = yaml.safe_load(content)
-                else:
-                    parsed = json.loads(content)
-            except (json.JSONDecodeError, UnicodeDecodeError) as e:
-                errors.append(f"Output '{output_name}' file '{path}': failed to parse: {e}")
-                continue
+                content = full_path.read_text(encoding="utf-8")
+                parsed = yaml.safe_load(content)
             except Exception as e:
-                # Covers yaml.YAMLError and other parsing failures
                 errors.append(f"Output '{output_name}' file '{path}': failed to parse: {e}")
                 continue
 

tests/unit/jobs/mcp/test_quality_gate.py

@@ -92,20 +92,20 @@ def test_passes_when_json_schema_validates(self, tmp_path: Path) -> None:
 
     # THIS TEST VALIDATES A HARD REQUIREMENT (JOBS-REQ-004.2.3).
     # YOU MUST NOT MODIFY THIS TEST UNLESS THE REQUIREMENT CHANGES
-    def test_fails_when_json_is_invalid(self, tmp_path: Path) -> None:
-        """Non-JSON content in the output file produces an error."""
+    def test_fails_when_file_is_unparseable(self, tmp_path: Path) -> None:
+        """Unparseable content in the output file produces an error."""
         schema = {"type": "object"}
         arg = StepArgument(
-            name="data", description="JSON data", type="file_path", json_schema=schema
+            name="data", description="data file", type="file_path", json_schema=schema
         )
         output_ref = StepOutputRef(argument_name="data", required=True)
         step = WorkflowStep(name="generate", outputs={"data": output_ref})
         job, _ = _make_job(tmp_path, [arg], step)
 
-        data_file = tmp_path / "data.json"
-        data_file.write_text("not json {{{")
+        data_file = tmp_path / "data.yml"
+        data_file.write_text(":\n  bad: [yaml\n  unclosed")
 
-        errors = validate_json_schemas({"data": "data.json"}, step, job, tmp_path)
+        errors = validate_json_schemas({"data": "data.yml"}, step, job, tmp_path)
         assert len(errors) == 1
         assert "failed to parse" in errors[0]
 
@@ -192,24 +192,6 @@ def test_fails_when_yaml_file_violates_schema(self, tmp_path: Path) -> None:
         assert len(errors) == 1
         assert "schema validation failed" in errors[0]
 
-    # THIS TEST VALIDATES A HARD REQUIREMENT (JOBS-REQ-004.2.3).
-    # YOU MUST NOT MODIFY THIS TEST UNLESS THE REQUIREMENT CHANGES
-    def test_fails_when_yaml_is_invalid(self, tmp_path: Path) -> None:
-        """Invalid YAML content produces a parse error."""
-        schema = {"type": "object"}
-        arg = StepArgument(
-            name="data", description="YAML data", type="file_path", json_schema=schema
-        )
-        output_ref = StepOutputRef(argument_name="data", required=True)
-        step = WorkflowStep(name="generate", outputs={"data": output_ref})
-        job, _ = _make_job(tmp_path, [arg], step)
-
-        data_file = tmp_path / "data.yml"
-        data_file.write_text(":\n  bad: [yaml\n  unclosed")
-
-        errors = validate_json_schemas({"data": "data.yml"}, step, job, tmp_path)
-        assert len(errors) == 1
-        assert "failed to parse" in errors[0]
 
 
 # ---------------------------------------------------------------------------