Skip to content

Commit a0cf300

Browse files
authored
Feedback from review
1 parent 22687d2 commit a0cf300

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

doc/policy_syntax.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class AuthService:
3636
trigger: src/**/*
3737
safety: README.md
3838
---
39-
Source code changed. Please verify README.md is accurate.
39+
Source code changed. Please verify README.md is accurate. Note that this is called only once even if there are many changes, so verify all changes.
4040

4141
Check that:
4242
- All public APIs are documented

doc/policy_system_design.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,14 @@ The following policies require attention:
306306
1. **Source/Test Pairing**: src/auth/login.py changed without tests/auth/login_test.py
307307
2. **Source/Test Pairing**: src/api/users.py changed without tests/api/users_test.py
308308
3. **API Documentation**: api/users.py changed without docs/api/users.md
309+
310+
[FEEDBACK] - these sections should all be shorter. Ex:
311+
## Source/Test Pairings
312+
src/auth/login.py changed without tests/auth/login_test.py
313+
src/api/users.py changed without tests/api/users_test.py
314+
315+
## API Documentation
316+
api/users.py changed without docs/api/users.md
309317
310318
## Code Quality (1)
311319

0 commit comments

Comments
 (0)