Skip to content

Commit b8c5e1f

Browse files
ncrmroclaude
andcommitted
refactor(library): remove Quality Criteria and Context sections from mech_engineer steps
Per CLAUDE.md: step instructions must not duplicate quality criteria already enforced by job.yml reviews, and must not include narrative Context sections. Removed both sections from all 13 step files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 53c74b4 commit b8c5e1f

13 files changed

Lines changed: 0 additions & 122 deletions

library/jobs/mech_engineer/steps/define_assembly_requirements.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,3 @@ Ask structured questions to gather the project name, design goal, and target qua
5858
- [List any unresolved items that need clarification before proceeding]
5959
```
6060

61-
## Quality Criteria
62-
63-
- Every function the assembly must perform is listed with a measurable acceptance criterion.
64-
- Size envelope, weight limits, mounting interfaces, and environmental conditions are documented.
65-
- Target production quantity is recorded and mapped to a scale tier.
66-
67-
## Context
68-
69-
This document is the single source of truth for all downstream steps. `source_ots_components` uses it to decide which sub-functions can be bought rather than built. `design_custom_parts` uses it to size and specify each custom part. `evaluate_manufacturability` uses it to determine appropriate manufacturing methods for the target scale.

library/jobs/mech_engineer/steps/define_ots_requirements.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,3 @@ Ask structured questions to understand what the OTS part must do, then produce a
6464
- [What the part must mate with, fit inside, or mount to]
6565
```
6666

67-
## Quality Criteria
68-
69-
- The part's required function is stated with enough detail to evaluate candidates against it.
70-
- Key dimensional constraints are documented.
71-
- Quantity needed and an acceptable unit cost range are recorded.
72-
73-
## Context
74-
75-
Precise requirements here prevent wasted time researching incompatible options. Over-constraining (specifying exact part numbers rather than requirements) limits the search; under-constraining leads to candidates that fail at integration. Strike the balance: specify the *need*, not the solution.

library/jobs/mech_engineer/steps/define_part_spec.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,3 @@ Ask structured questions to understand the part's function, load conditions, int
7676
- [Any unclear requirements to resolve before manufacturing method selection]
7777
```
7878

79-
## Quality Criteria
80-
81-
- The part's primary function is stated with measurable acceptance criteria.
82-
- Mating surfaces, fastener patterns, and dimensional constraints are documented.
83-
- Forces, temperatures, and environmental conditions the part must withstand are recorded.
84-
85-
## Context
86-
87-
This specification feeds directly into `select_manufacturing_method`. A well-defined spec prevents back-and-forth with fabricators and enables accurate cost estimation. If any requirements are ambiguous, resolve them here before proceeding.

library/jobs/mech_engineer/steps/design_custom_parts.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,3 @@ Read the assembly requirements and OTS component list to identify every sub-func
7070
[Repeat for each custom part]
7171
```
7272

73-
## Quality Criteria
74-
75-
- Each custom part has a manufacturing method matched to the target production scale.
76-
- Each part has a recommended material with justification.
77-
- No custom part duplicates an available OTS option from the prior step.
78-
- Each part references an existing model source file (toolchain-appropriate format per agent.md) or includes notes on what geometry to create.
79-
80-
## Context
81-
82-
This step determines the core fabrication workload and cost of the assembly. Under-specifying parts here leads to fabrication errors and rework. The output feeds directly into BOM cost estimation and scale evaluation.

library/jobs/mech_engineer/steps/document_part.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,3 @@ Merge the part spec and manufacturing specification into a clean datasheet, veri
7373
- [Any unresolved items before fabrication can begin]
7474
```
7575

76-
## Quality Criteria
77-
78-
- Datasheet includes all fields needed to order fabrication or add the part to a BOM.
79-
- A model source file path (toolchain-appropriate format per agent.md) or model creation instructions are included.
80-
- A fabricator could produce the part from this datasheet without additional information.
81-
82-
## Context
83-
84-
This is the final output of the `design_part` workflow. The datasheet can be attached to a purchase order, included in a BOM, or handed to a fabricator directly. Keep it concise — one page is the target. Move long derivations or analysis to appendices if needed.

library/jobs/mech_engineer/steps/evaluate_manufacturability.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,3 @@ Read the assembly requirements (for the target scale context) and the BOM (for p
101101
| [part_name] | OTS | OTS | OTS (volume buy) |
102102
```
103103

104-
## Quality Criteria
105-
106-
- Evaluation explicitly addresses prototype, small-batch, and production scale tiers.
107-
- Total unit cost is calculated for each tier.
108-
- Parts whose manufacturing method should change between tiers are explicitly identified with justification.
109-
- High-cost or long-lead items that dominate the BOM at each scale are identified with mitigation suggestions.
110-
111-
## Context
112-
113-
This is the final step of the `design_assembly` workflow. The output drives sourcing strategy, investment timing (e.g., when to order mold tooling), and product pricing. The `evaluate_at_scale` workflow uses a similar analysis for existing assemblies without re-running the full design flow.

library/jobs/mech_engineer/steps/generate_bom.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,3 @@ Read the OTS components list and custom parts plan, then produce a complete BOM.
4949
- [Any sourcing caveats, substitution options, or procurement dependencies]
5050
```
5151

52-
## Quality Criteria
53-
54-
- BOM includes every OTS component and custom part from the assembly.
55-
- Each line item has a unit cost and extended cost; a total assembly cost is summed.
56-
- Each OTS part has a supplier; custom parts note fabrication method in the supplier column.
57-
- Lead time or fabrication time estimate is provided for each line item.
58-
59-
## Context
60-
61-
The BOM is used directly by `evaluate_manufacturability` to calculate per-unit cost across scale tiers and identify high-cost or long-lead items. Accuracy here is critical — gaps in cost or lead time will degrade the quality of scale recommendations.

library/jobs/mech_engineer/steps/load_assembly_bom.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,3 @@ Ask structured questions to locate the BOM and requirements files, then normaliz
6060
- Lines with missing lead time: [list or "none"]
6161
```
6262

63-
## Quality Criteria
64-
65-
- Normalized BOM includes part name, quantity, unit cost, supplier, and manufacturing method for every line item.
66-
- Design requirements (function, constraints, quantity target) are present as context for the analysis.
67-
- The tiers to evaluate are explicitly listed.
68-
69-
## Context
70-
71-
This step is the entry point for the `evaluate_at_scale` workflow when applied to an existing assembly. The normalized context file is the sole input to `run_scale_analysis` — accuracy here directly determines the quality of scale recommendations.

library/jobs/mech_engineer/steps/research_ots_options.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,3 @@ Read the OTS requirements document, search supplier catalogs, and record candida
7575
| MOQ | [qty] | [qty] | [qty] |
7676
```
7777

78-
## Quality Criteria
79-
80-
- At least three distinct candidate parts are documented (or all available options if fewer exist in the market).
81-
- Each candidate's specifications are verified against the requirements document.
82-
- Unit cost and minimum order quantity are recorded for each candidate.
83-
84-
## Context
85-
86-
The quality of this research directly determines whether the selected part will work. Do not include candidates that fail a functional or dimensional requirement — note their failure and exclude them. If fewer than three options exist that meet all requirements, document all available options and note the constraint.

library/jobs/mech_engineer/steps/run_scale_analysis.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,3 @@ Read `bom_context.md`, apply scale-tier logic, and produce a structured report c
102102
| [part] | [method] | [method] | [method] |
103103
```
104104

105-
## Quality Criteria
106-
107-
- Every requested scale tier is analyzed.
108-
- Total unit cost is calculated for each tier.
109-
- Parts that should change manufacturing method between tiers are explicitly called out with the break-even quantity.
110-
- Each tier includes 1–3 concrete recommendations to reduce cost or lead time.
111-
112-
## Context
113-
114-
This is the final step of the `evaluate_at_scale` workflow and mirrors the analysis in `evaluate_manufacturability` at the end of `design_assembly`. The output is intended for engineering and business stakeholders deciding when to invest in tooling, volume purchasing, or process transitions.

0 commit comments

Comments
 (0)