Commit c1a4eab
committed
Fix merge queue checks by ensuring consistent job names across events
GitHub has a known bug where PRs that are up-to-date with the target
branch may trigger fast-forward merges. When this happens, GitHub looks
for check statuses on the PR commit instead of triggering merge_group
workflows.
Previously, claude-code-test.yml had different job names for PR vs
merge_group events:
- pr-check: ran on pull_request
- validate-generation: ran only on merge_group
- claude-code-e2e: ran only on merge_group
When GitHub's fast-forward optimization kicked in, it couldn't find
validate-generation or claude-code-e2e checks on the PR commit because
those jobs never ran for PRs.
Fix: Make validate-generation and claude-code-e2e run on BOTH events,
with step-level conditions to skip actual work on PRs. This ensures
the check names exist for PRs, working around GitHub's merge queue bug.
See: https://github.com/orgs/community/discussions/1511001 parent b6bc46b commit c1a4eab
1 file changed
Lines changed: 22 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 31 | | |
40 | | - | |
| 32 | + | |
| 33 | + | |
41 | 34 | | |
42 | 35 | | |
43 | | - | |
44 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
45 | 42 | | |
| 43 | + | |
46 | 44 | | |
47 | 45 | | |
| 46 | + | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
| 62 | + | |
61 | 63 | | |
62 | 64 | | |
63 | 65 | | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
| |||
100 | 103 | | |
101 | 104 | | |
102 | 105 | | |
103 | | - | |
| 106 | + | |
| 107 | + | |
104 | 108 | | |
105 | 109 | | |
106 | 110 | | |
107 | | - | |
108 | 111 | | |
109 | 112 | | |
110 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
111 | 119 | | |
| 120 | + | |
112 | 121 | | |
113 | 122 | | |
| 123 | + | |
114 | 124 | | |
115 | 125 | | |
116 | 126 | | |
| |||
0 commit comments