Skip to content

Commit f992a75

Browse files
ncrmroclaude
andcommitted
fix(library): address Copilot review comments on marketing job
- Remove external convention references (process.notes, tool.zk-notes, ZK_NOTEBOOK_DIR) from README and AGENTS.md for portability - Use platform-neutral "sub-agents" wording instead of "Agent tool" - Fix manifest template to reference research job's README.md output - Fix cca_analyze_patterns to read README.md files from manifest Skipped: CLAUDE.md symlink comment (incorrect — it IS a symlink), step duplication (known trade-off, non-blocking) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 8526581 commit f992a75

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

library/jobs/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ Library jobs that produce durable outputs (reports, research, decisions) should
7575

7676
**How it works in practice**:
7777

78-
1. The job's `discover_context` step checks `NOTES_DIR` or `ZK_NOTEBOOK_DIR` and reads the AGENTS.md there.
79-
2. The agent's platform conventions (e.g., `process.notes`, `tool.zk-notes`) provide the mechanics for note creation.
78+
1. The job's `discover_context` step checks for a user-configured notes directory (e.g., via `NOTES_DIR`) and reads the AGENTS.md there when available.
79+
2. The user's environment-specific conventions provide the mechanics for note creation.
8080
3. If no notes directory exists, the job falls back to `.deepwork/tmp/` with plain markdown.
8181

82-
This separation means the same library job works for a Keystone user with a zk notebook, an Obsidian user, or someone with no notes system at all.
82+
This separation means the same library job works for users with different note-taking setups, as well as someone with no notes system at all.
8383

8484
## Structure
8585

library/jobs/marketing/AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ to `.deepwork/tmp/` only if no notes directory exists.
5454
This job does not embed note creation mechanics (zk commands, frontmatter
5555
format, tag conventions) because those vary by user setup. The user's notes
5656
repo AGENTS.md and the agent's platform conventions are the source of truth for
57-
how to create notes. See `process.notes` and `tool.zk-notes` for the canonical
58-
rules if available in the agent's instruction context.
57+
how to create notes. Follow the user's notes-directory conventions and any
58+
applicable instructions available in the agent's instruction context.
5959

6060
## Quality review learnings
6161

library/jobs/marketing/job.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,8 @@ workflows:
275275
- `inputs`: `topic` = "[Competitor Name] content strategy: [content focus areas]",
276276
`type` = "competitive", `depth` = "quick"
277277
278-
Launch all competitors in parallel using the Agent tool — one
279-
agent per competitor, each calling `start_workflow` independently.
278+
Launch all competitors in parallel by spawning sub-agents — one
279+
per competitor, each calling `start_workflow` independently.
280280
281281
The research job produces `sources.md`, `analysis.md`, and
282282
`README.md` per competitor — the README serves as the competitor
@@ -311,8 +311,8 @@ workflows:
311311
312312
| Competitor | Report path | Key finding |
313313
|-----------|-------------|-------------|
314-
| [Name 1] | [path/to/competitor_report.md] | [One-line summary] |
315-
| [Name 2] | [path/to/competitor_report.md] | [One-line summary] |
314+
| [Name 1] | [path/to/research/README.md] | [One-line summary] |
315+
| [Name 2] | [path/to/research/README.md] | [One-line summary] |
316316
317317
## Failures (if any)
318318
@@ -347,7 +347,7 @@ workflows:
347347
348348
1. **Read inputs**
349349
- Read competitor_reports_manifest.md to find all report paths.
350-
- Read each competitor_report.md file referenced in the manifest.
350+
- Read each report file (README.md) referenced in the manifest.
351351
352352
2. **Cross-competitor analysis**
353353

0 commit comments

Comments
 (0)