Skip to content

Commit fc8e1bf

Browse files
nhortonclaude
andauthored
fix: streamline /review skill to skip preflight check (#326)
The review skill was calling get_configured_reviews before get_review_instructions, adding an unnecessary round-trip. The latter already returns a clear message when no rules exist, so the preflight step is redundant. Go straight to get_review_instructions and handle the no-rules case inline. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c4ac229 commit fc8e1bf

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

plugins/claude/skills/review/SKILL.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,12 @@ Only proceed past this section if the user wants to **run** reviews.
1818

1919
## How to Run
2020

21-
1. First, call `mcp__deepwork__get_configured_reviews` to see what review rules are configured. This returns each rule's name, description, and which `.deepreview` file defines it. If reviewing specific files, pass `only_rules_matching_files` to see only the rules that apply. Share a brief summary of the active rules with the user before proceeding.
22-
- **If no rules are configured**:
23-
1. Use AskUserQuestion to tell the user there are no `.deepreview` rules set up yet and ask if they'd like the agent to auto-discover and suggest rules for this project.
24-
2. If yes, invoke the `/deepwork` skill with the `deepwork_reviews` job's `discover_rules` workflow (which sets up native reviews, skill migration, documentation rules, and language-specific code review).
25-
3. Stop here — do not proceed with running reviews if there are no rules.
26-
2. Call the `mcp__deepwork__get_review_instructions` tool:
21+
1. Call the `mcp__deepwork__get_review_instructions` tool directly:
2722
- **No arguments** to review the current branch's changes (auto-detects via git diff against the main branch).
2823
- **With `files`** to review only specific files: `mcp__deepwork__get_review_instructions(files=["src/app.py", "src/lib.py"])`. When provided, only reviews whose include/exclude patterns match the given files will be returned. Use this when the user asks to review a particular file or set of files rather than the whole branch.
29-
3. The output will list review tasks to invoke in parallel. Each task has `name`, `description`, `subagent_type`, and `prompt` fields — these map directly to the Task tool parameters. Launch all of them as parallel Task agents.
30-
4. Collect the results from all review agents.
24+
- **If the result says no rules are configured**: Ask the user if they'd like to auto-discover and set up rules. If yes, invoke the `/deepwork` skill with the `deepwork_reviews` job's `discover_rules` workflow. Stop here — do not proceed with running reviews if there are no rules.
25+
2. The output will list review tasks to invoke in parallel. Each task has `name`, `description`, `subagent_type`, and `prompt` fields — these map directly to the Task tool parameters. Launch all of them as parallel Task agents.
26+
3. Collect the results from all review agents.
3127

3228
## Acting on Results
3329

0 commit comments

Comments
 (0)