Skip to content

Commit eeac054

Browse files
tildesrcclaude
andcommitted
docs: rename per-state advance β†’ advanced_by
`.advance` read like a command (it clashes with the `/advance` operation); `advanced_by` is the noun form and parallels `turn_on_enter`. The `/advance` core op keeps its name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 26f9124 commit eeac054

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

β€Ždocs/ARCHITECTURE.mdβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ registration. Sketch of the ABC's two faces:
169169

170170
- **Declarative members** (data the control plane reads):
171171
- `states` (nested `State` classes) and their `transitions` (class refs or label strings);
172-
- per-state `turn_on_enter` (who holds the turn on entry) and `advance` (who transitions
172+
- per-state `turn_on_enter` (who holds the turn on entry) and `advanced_by` (who transitions
173173
out: `USER` β€” the default β€” / `AGENT` once satisfied);
174174
- `responsibilities(state)` β†’ the agent's obligations for that state (each resolves to a
175175
`status`: `PENDING` β†’ `MET`/`FAILED`, a `FAILED` one needs a comment);
@@ -199,7 +199,7 @@ active workflow*, not a fixed global list.
199199
creds volume (references, **never secret values**).
200200
- **Task** β€” stable internal **id** (generated at creation), `repo_id`, `workflow`, current
201201
`state`, **`turn`** (`agent`/`user`), git refs (branch/worktree), optional
202-
forge refs (PR), and an **optional `slug`** (see Β§8.3). (Per-state `turn_on_enter`/`advance`
202+
forge refs (PR), and an **optional `slug`** (see Β§8.3). (Per-state `turn_on_enter`/`advanced_by`
203203
live on the `State` classes, not the task.)
204204
- **History** β€” append-only transition log per task. Each entry: timestamp, from/to state,
205205
via, and the **responsibilities resolved that turn** (each with its `status` and, if

β€Ždocs/BACKLOG.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ in the ADRs; this file is for the smaller stuff that doesn't have a home there y
1919
Pin/upgrade once the ecosystem settles. _(Slice 1, P3)_
2020
- [ ] **CI doesn't type-check `tests/`** β€” `mypy -p panopticon` covers the package only.
2121
Consider adding `mypy tests` (needs path/namespace config). _(Slice 1, P3)_
22-
- [ ] **`advance` is declared but not engine-enforced** β€” a state's `advance`
22+
- [ ] **`advanced_by` is declared but not engine-enforced** β€” a state's `advanced_by`
2323
(`USER`/`AGENT`) is queryable metadata; the engine doesn't yet use it to decide who
2424
may trigger a transition, nor is there a per-*transition* auto-advance flag. Wire it when
2525
the agent runtime needs it (around the parity workflow, Slice 4). _(Slice 1, P2)_

β€Ždocs/decisions/0004-workflow-abstraction.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Within the class, the two kinds of responsibility are expressed differently:
6262
- the **state set and legal transitions** (the state machine);
6363
- per-state **`turn_on_enter`** (who holds the turn on entry) β€” the agnostic turn-tracking
6464
starts from it;
65-
- per-state **`advance`** β€” who transitions out: `USER` (the default β€” e.g. approving a
65+
- per-state **`advanced_by`** β€” who transitions out: `USER` (the default β€” e.g. approving a
6666
plan) or `AGENT` (the agent does so once satisfied);
6767
- the **responsibilities** per state β€” the agent's obligations to fulfil before handing
6868
the turn back. Each resolves to a **status** (`PENDING` β†’ `MET`/`FAILED`; a `FAILED`

0 commit comments

Comments
Β (0)