Skip to content

Commit 11476cb

Browse files
authored
fix(lbaas): fix resolver request spelling (#145)
1 parent 64b9c9d commit 11476cb

5 files changed

Lines changed: 14 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@ See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
55

66
## [Unreleased]
77

8+
### Fixed
9+
- Managed Load Balancer resolver request spelling
10+
811
## [4.4.1]
912

1013
### Added
1114
- Managed Load Balancer request example
1215

1316
### Fixed
14-
- num_members_up matcher naming convention
17+
- Managed Load Balancer num_members_up matcher naming convention
1518

1619
## [4.4.0]
1720

upcloud/request/load_balancer.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,18 +249,18 @@ func (r *CreateLoadBalancerResolverRequest) RequestURL() string {
249249
return fmt.Sprintf("/load-balancer/%s/resolvers", r.ServiceUUID)
250250
}
251251

252-
// ModifyLoadBalancerRevolverRequest represents a request to modify load balancer resolver
253-
type ModifyLoadBalancerRevolverRequest struct {
252+
// ModifyLoadBalancerResolverRequest represents a request to modify load balancer resolver
253+
type ModifyLoadBalancerResolverRequest struct {
254254
ServiceUUID string `json:"-"`
255255
Name string `json:"-"`
256256
Resolver LoadBalancerResolver
257257
}
258258

259-
func (r *ModifyLoadBalancerRevolverRequest) MarshalJSON() ([]byte, error) {
259+
func (r *ModifyLoadBalancerResolverRequest) MarshalJSON() ([]byte, error) {
260260
return json.Marshal(r.Resolver)
261261
}
262262

263-
func (r *ModifyLoadBalancerRevolverRequest) RequestURL() string {
263+
func (r *ModifyLoadBalancerResolverRequest) RequestURL() string {
264264
return fmt.Sprintf("/load-balancer/%s/resolvers/%s", r.ServiceUUID, r.Name)
265265
}
266266

upcloud/request/load_balancer_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ func TestGetLoadBalancerResolverRequest(t *testing.T) {
466466
}
467467

468468
func TestModifyLoadBalancerResolverRequest(t *testing.T) {
469-
r := ModifyLoadBalancerRevolverRequest{
469+
r := ModifyLoadBalancerResolverRequest{
470470
ServiceUUID: "service-uuid",
471471
Name: "sesese",
472472
Resolver: LoadBalancerResolver{
@@ -495,7 +495,7 @@ func TestModifyLoadBalancerResolverRequest(t *testing.T) {
495495
assert.EqualValues(t, "/load-balancer/service-uuid/resolvers/sesese", r.RequestURL())
496496
assert.JSONEq(t, expectedJson, string(actualJson))
497497

498-
r = ModifyLoadBalancerRevolverRequest{
498+
r = ModifyLoadBalancerResolverRequest{
499499
ServiceUUID: "service-uuid",
500500
Name: "sesese",
501501
Resolver: LoadBalancerResolver{

upcloud/service/load_balancer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ type LoadBalancer interface {
2929
GetLoadBalancerResolvers(r *request.GetLoadBalancerResolversRequest) ([]upcloud.LoadBalancerResolver, error)
3030
CreateLoadBalancerResolver(r *request.CreateLoadBalancerResolverRequest) (*upcloud.LoadBalancerResolver, error)
3131
GetLoadBalancerResolver(r *request.GetLoadBalancerResolverRequest) (*upcloud.LoadBalancerResolver, error)
32-
ModifyLoadBalancerResolver(r *request.ModifyLoadBalancerRevolverRequest) (*upcloud.LoadBalancerResolver, error)
32+
ModifyLoadBalancerResolver(r *request.ModifyLoadBalancerResolverRequest) (*upcloud.LoadBalancerResolver, error)
3333
DeleteLoadBalancerResolver(r *request.DeleteLoadBalancerResolverRequest) error
3434
// Plans
3535
GetLoadBalancerPlans(r *request.GetLoadBalancerPlansRequest) ([]upcloud.LoadBalancerPlan, error)
@@ -341,7 +341,7 @@ func (s *Service) GetLoadBalancerResolver(r *request.GetLoadBalancerResolverRequ
341341
}
342342

343343
// ModifyLoadBalancerResolver modifies an existing load balancer resolver.
344-
func (s *Service) ModifyLoadBalancerResolver(r *request.ModifyLoadBalancerRevolverRequest) (*upcloud.LoadBalancerResolver, error) {
344+
func (s *Service) ModifyLoadBalancerResolver(r *request.ModifyLoadBalancerResolverRequest) (*upcloud.LoadBalancerResolver, error) {
345345
var resolver upcloud.LoadBalancerResolver
346346

347347
reqBody, err := json.Marshal(r)

upcloud/service/load_balancer_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ func TestLoadBalancerResolver(t *testing.T) {
271271
newTimeout := 30
272272

273273
t.Logf("Update resolver: %s", name)
274-
resolver, err = svc.ModifyLoadBalancerResolver(&request.ModifyLoadBalancerRevolverRequest{
274+
resolver, err = svc.ModifyLoadBalancerResolver(&request.ModifyLoadBalancerResolverRequest{
275275
ServiceUUID: lb.UUID,
276276
Name: resolver.Name,
277277
Resolver: request.LoadBalancerResolver{
@@ -292,7 +292,7 @@ func TestLoadBalancerResolver(t *testing.T) {
292292
newTimeoutRetry := 15
293293
newCacheValid := 124
294294
newCacheInvalid := 324
295-
resolver, err = svc.ModifyLoadBalancerResolver(&request.ModifyLoadBalancerRevolverRequest{
295+
resolver, err = svc.ModifyLoadBalancerResolver(&request.ModifyLoadBalancerResolverRequest{
296296
ServiceUUID: lb.UUID,
297297
Name: resolver.Name,
298298
Resolver: request.LoadBalancerResolver{

0 commit comments

Comments
 (0)