udpsink: set fd to -1 if URI is NULL

funman · cmassiot · commit 18904c40d259 · 2024-11-10T16:32:08.000+01:00
diff --git a/lib/upipe-modules/upipe_udp_sink.c b/lib/upipe-modules/upipe_udp_sink.c
@@ -408,7 +408,7 @@ static int _upipe_udpsink_set_uri(struct upipe *upipe, const char *uri)
     if (unlikely(upipe_udpsink->fd != -1)) {
         if (likely(upipe_udpsink->uri != NULL))
             upipe_notice_va(upipe, "closing socket %s", upipe_udpsink->uri);
-        close(upipe_udpsink->fd);
+        ubase_clean_fd(&upipe_udpsink->fd);
     }
     ubase_clean_str(&upipe_udpsink->uri);
     upipe_udpsink_set_upump(upipe, NULL);

Original file line number	Diff line number	Diff line change
`@@ -408,7 +408,7 @@ static int _upipe_udpsink_set_uri(struct upipe upipe, const char uri)`
`408`	`408`	`if (unlikely(upipe_udpsink->fd != -1)) {`
`409`	`409`	`if (likely(upipe_udpsink->uri != NULL))`
`410`	`410`	`upipe_notice_va(upipe, "closing socket %s", upipe_udpsink->uri);`
`411`		`- close(upipe_udpsink->fd);`
	`411`	`+ ubase_clean_fd(&upipe_udpsink->fd);`
`412`	`412`	`}`
`413`	`413`	`ubase_clean_str(&upipe_udpsink->uri);`
`414`	`414`	`upipe_udpsink_set_upump(upipe, NULL);`