add descriptions to cartridge implementations

- add `PakGetDescription` to each cartridge
- add cartridge description to the string table of each pak
- update `cartridge` to export description as a property function
- update `legacy_cartridge` to support PakGetDescription

Author: ChetSimpson

FD502/fd502.cpp

@@ -125,6 +125,15 @@ extern "C"
 		return string_buffer;
 	}
 
+	__declspec(dllexport) const char* PakGetDescription()
+	{
+		static char string_buffer[MAX_LOADSTRING];
+
+		LoadString(gModuleInstance, IDS_DESCRIPTION, string_buffer, MAX_LOADSTRING);
+
+		return string_buffer;
+	}
+
 	__declspec(dllexport) void PakInitialize(
 		void* const host_key,
 		const char* const configuration_path,

FD502/fd502.rc

@@ -164,7 +164,7 @@ BEGIN
             VALUE "FileDescription", "DiskController"
             VALUE "FileVersion", "2.1.8.1"
             VALUE "InternalName", "DiskController"
-            VALUE "LegalCopyright", "Copyright � 2010"
+            VALUE "LegalCopyright", "Copyright � 2010"
             VALUE "OriginalFilename", "fd502.dll"
             VALUE "ProductName", "Vcc Module file"
             VALUE "ProductVersion", "26-3133"
@@ -198,6 +198,7 @@ STRINGTABLE
 BEGIN
     IDS_MODULE_NAME         "FD-502"
     IDS_VERSION             "3.0.1"
+    IDS_DESCRIPTION         "Turn any Color Computer with Extended BASIC into a disk system. Write your own disk applications or add ready-to-run software. Plugs into the Program Pak port or Multi-Pak Interface."
 #ifdef COMBINE_BECKER
     IDS_CATNUMBER           "+ Becker"
 #else

FD502/resource.h

@@ -5,6 +5,7 @@
 #define IDS_MODULE_NAME                 1
 #define IDS_VERSION                     2
 #define IDS_CATNUMBER                   3
+#define IDS_DESCRIPTION                 4
 #define IDD_CONFIG                      101
 #define IDD_NEWDISK                     102
 #define IDC_DRIVE0                      1000

GMC/Cartridge.cpp

@@ -1,4 +1,5 @@
 #include "Cartridge.h"
+#include <vcc/core/utils/winapi.h>
 
 
 namespace detail
@@ -11,10 +12,7 @@ namespace detail
 Cartridge* Cartridge::m_Singleton(nullptr);
 
 
-Cartridge::Cartridge(std::string name, std::string catalogId)
-	:
-	m_Name(move(name)),
-	m_CatalogId(move(catalogId))
+Cartridge::Cartridge()
 {
 	if (m_Singleton)
 	{
@@ -45,21 +43,6 @@ void Cartridge::LoadMenuItems()
 
 
 
-
-std::string Cartridge::GetName() const
-{
-	return m_Name;
-}
-
-
-std::string Cartridge::GetCatalogId() const
-{
-	return m_CatalogId;
-}
-
-
-
-
 void Cartridge::SetHostKey(void* key)
 {
 	m_HostKey = key;

GMC/Cartridge.h

@@ -7,15 +7,13 @@ class Cartridge
 {
 protected:
 
-	explicit Cartridge(std::string name, std::string catalogId = std::string());
+	Cartridge();
 
 
 public:
 
 	virtual ~Cartridge();
 
-	virtual std::string GetName() const;
-	virtual std::string GetCatalogId() const;
 
 	virtual void SetHostKey(void* key);
 	virtual void SetCartLineAssertCallback(PakAssertCartridgeLineHostCallback callback);

GMC/CartridgeTrampolines.cpp

@@ -1,17 +1,37 @@
 #include "CartridgeTrampolines.h"
 #include "Cartridge.h"
+#include "resource.h"
+#include <vcc/core/limits.h>
 
 
 GMC_EXPORT const char* PakGetName()
 {
-	return Cartridge::m_Singleton->GetName().c_str();
+	static char string_buffer[MAX_LOADSTRING];
+
+	LoadString(gModuleInstance, IDS_MODULE_NAME, string_buffer, MAX_LOADSTRING);
+
+	return string_buffer;
 }
 
 GMC_EXPORT const char* PakCatalogName()
 {
-	return Cartridge::m_Singleton->GetCatalogId().c_str();
+	static char string_buffer[MAX_LOADSTRING];
+
+	LoadString(gModuleInstance, IDS_CATNUMBER, string_buffer, MAX_LOADSTRING);
+
+	return string_buffer;
+}
+
+GMC_EXPORT const char* PakGetDescription()
+{
+	static char string_buffer[MAX_LOADSTRING];
+
+	LoadString(gModuleInstance, IDS_DESCRIPTION, string_buffer, MAX_LOADSTRING);
+
+	return string_buffer;
 }
 
+
 GMC_EXPORT void PakInitialize(
 	void* const host_key,
 	const char* const configuration_path,

GMC/GMC.h

@@ -9,6 +9,7 @@
 #define GMC_EXPORT
 #endif
 
+extern HINSTANCE gModuleInstance;
 std::string SelectROMFile();
 std::string ExtractFilename(std::string path);
 

GMC/GMC.rc

@@ -71,7 +71,7 @@ BEGIN
             VALUE "FileDescription", "GMC"
             VALUE "FileVersion", "2.1.8.1"
             VALUE "InternalName", "orch90"
-            VALUE "LegalCopyright", "Copyright � 2019"
+            VALUE "LegalCopyright", "Copyright � 2019"
             VALUE "OriginalFilename", "gmc.dll"
             VALUE "ProductName", "Game Master Cartridge (SN76489)"
             VALUE "ProductVersion", "26-XXXX"
@@ -84,6 +84,20 @@ BEGIN
     END
 END
 
+
+/////////////////////////////////////////////////////////////////////////////
+//
+// String Table
+//
+
+STRINGTABLE
+BEGIN
+    IDS_MODULE_NAME         "Game Master Catridge"
+    IDS_CATNUMBER           "26-XXXX"
+    IDS_DESCRIPTION         "[TODO: DESCRIPTION]"
+    IDS_VERSION             "1.0"
+END
+
 #endif    // English (United States) resources
 /////////////////////////////////////////////////////////////////////////////
 

GMC/GMCCartridge.cpp

@@ -2,11 +2,6 @@
 #include <Windows.h>
 
 
-GMCCartridge::GMCCartridge()
-	: Cartridge("Game Master Catridge", "SN76489")
-{}
-
-
 void GMCCartridge::LoadConfiguration(const std::string& filename)
 {
 	Cartridge::LoadConfiguration(filename);

GMC/GMCCartridge.h

@@ -9,8 +9,6 @@ class GMCCartridge : public Cartridge
 {
 public:
 
-	GMCCartridge();
-
 	void LoadConfiguration(const std::string& filename) override;
 
 	std::string GetStatusMessage() const override;