Skip to content

v492 development #299

@GernotMaier

Description

@GernotMaier

Main goals for v492:

  • improve efficiency of IRF calculation (lower storage footprint; introduce possibility to re-calculate all stereo parameters (MSCW, MSCL, emission height, direction, core, energy) on the mscw_energy level for 3-telescope events from 4-telescope MC simulations. This is for MC events only and used to simplify and accelerate the analysis required for the generation of effective areas.)
    • script improvement to run mscw_energy and effective area code for 4 and 3-telescope arrays in one job.
  • bug fixes related to 3-telescope analysis
  • soft cuts
  • efficiency improvements in number of calls to TMVA evaluator in gamma/hadron cuts: interpolation of MVA cuts
    • (UMA2 skymap).

List of changes:

  • reduced storage impact of mscw_energy branch (mostly due to change of doubles to floats; removal of unused variables); reduction is on storage requirements is ~25%.
  • efficiency improvement in running mscw_energy -> 20% faster
  • fine-tuning of docker build scripts to improve build efficiency
  • add code to redo stereo reconstruction to CData.cpp. Functions are named reconstruct_3tel_images*
  • generalized calculation of MSCW, MSCL, MWR, MWL variables in new classes VMeanScaledVariables
  • allow to recalculate dispBDTDirection and dispBDTEnergy in VDispAnalyzer from values per image
  • several important improvements and bug fixes in stereo reconstruction code in VTableLookupDataHandler:
    • Chi2 from direction reconstruction not correctly filled from showerpars trees
    • bug fix in setting of NImages and selected telescopes for 3-telescope runs (function fill_selected_images_before_redo_stereo_reconstruction)
  • clarified that Erec is from dispBDTEnergy while ErecS is from simple lookup table reconstruction. Change default values for EnergyReconstructionMethod to Erec (method ID 0) for anasum and effective area code.
  • introduced consistent naming of tree reader support classes. Moved them from .C to .cpp. Removed obsolete code in these files.
  • removed Version from CData class initialize (as it is read from tree doc string).
  • removal of CEffFit.h classes (not used anywhere)
  • bug fix in SizeSecondMax calculation for 3-tel reconstruction using in mscw_energy the rec_id option (no image selection was applied)
  • maintenance and cleanup of obsolete files (see PR v492 dev5 - maintenance #294)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions