Skip to content

Commit 1d8da2f

Browse files
committed
vey-io-ext: add more testcases
1 parent 542ec64 commit 1d8da2f

18 files changed

Lines changed: 3551 additions & 22 deletions

File tree

lib/vey-icap-client/src/options/response.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,10 +305,7 @@ mod tests {
305305
.parse_header_line(b"Max-Connections: 100\r\n")
306306
.unwrap();
307307
assert_eq!(options.server.as_deref(), Some("Example ICAP Server 1.0"));
308-
assert_eq!(
309-
options.service_tag,
310-
"\"W3E4R7U9-L3E4R7U9-W3E4R7U9\""
311-
);
308+
assert_eq!(options.service_tag, "\"W3E4R7U9-L3E4R7U9-W3E4R7U9\"");
312309
assert_eq!(options.service_id.as_deref(), Some("respmod-scan"));
313310
assert_eq!(options.max_connections, Some(100));
314311
options.check().unwrap();

lib/vey-icap-client/src/service/config/mod.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,7 @@ impl IcapServiceConfig {
156156
"icaps" => 11344,
157157
_ => 1344,
158158
};
159-
let include_port = self
160-
.url
161-
.port()
162-
.is_some_and(|port| port != default_port);
159+
let include_port = self.url.port().is_some_and(|port| port != default_port);
163160

164161
match host {
165162
url::Host::Domain(domain) => {

lib/vey-io-ext/src/limit/token_bucket/stream.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,6 @@ mod tests {
139139
let limiter = GlobalStreamLimiter::new(GlobalLimitGroup::User, config);
140140
assert!(matches!(limiter.group(), GlobalLimitGroup::User));
141141
assert_eq!(limiter.check(10), StreamLimitAction::AdvanceBy(10));
142-
assert!(matches!(
143-
limiter.check(1),
144-
StreamLimitAction::DelayUntil(_)
145-
));
142+
assert!(matches!(limiter.check(1), StreamLimitAction::DelayUntil(_)));
146143
}
147144
}

lib/vey-io-ext/src/stream/ext/limited_write_ext.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,11 @@ mod tests {
4646
#[tokio::test]
4747
async fn write_all_vectored_writes_all_slices() {
4848
let mut writer = Vec::new();
49-
let bufs = [IoSlice::new(b"ab"), IoSlice::new(b"cd"), IoSlice::new(b"ef")];
49+
let bufs = [
50+
IoSlice::new(b"ab"),
51+
IoSlice::new(b"cd"),
52+
IoSlice::new(b"ef"),
53+
];
5054
writer.write_all_vectored(bufs).await.unwrap();
5155
// Vec's AsyncWrite may not implement vectored specially; still should complete.
5256
writer.flush().await.unwrap();

lib/vey-io-ext/src/udp/mod.rs

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,4 +141,61 @@ mod tests {
141141
cfg.set_batch_count(4);
142142
assert_eq!(cfg.underlying_buffer_size(), 1024 * 4);
143143
}
144+
145+
#[test]
146+
fn underlying_buffer_size_caps_the_batch_used_as_floor() {
147+
let mut cfg = LimitedUdpRelayConfig::default();
148+
cfg.set_underlying_buffer_size(0);
149+
cfg.set_packet_size(1024);
150+
cfg.set_batch_count(1024);
151+
assert_eq!(
152+
cfg.underlying_buffer_size(),
153+
1024 * DEFAULT_UDP_RELAY_BATCH_COUNT
154+
);
155+
}
156+
157+
#[test]
158+
fn underlying_buffer_size_keeps_the_larger_explicit_value() {
159+
let mut cfg = LimitedUdpRelayConfig::default();
160+
cfg.set_packet_size(MINIMUM_UDP_PACKET_SIZE);
161+
cfg.set_batch_count(1);
162+
cfg.set_underlying_buffer_size(1 << 20);
163+
assert_eq!(cfg.underlying_buffer_size(), 1 << 20);
164+
}
165+
166+
#[test]
167+
fn underlying_buffer_size_with_zero_batch_falls_back_to_explicit_value() {
168+
let mut cfg = LimitedUdpRelayConfig::default();
169+
cfg.set_batch_count(0);
170+
cfg.set_underlying_buffer_size(64);
171+
assert_eq!(cfg.underlying_buffer_size(), 64);
172+
}
173+
174+
#[test]
175+
fn set_packet_size_accepts_the_exact_bounds() {
176+
let mut cfg = LimitedUdpRelayConfig::default();
177+
cfg.set_packet_size(MINIMUM_UDP_PACKET_SIZE);
178+
assert_eq!(cfg.packet_size(), MINIMUM_UDP_PACKET_SIZE);
179+
cfg.set_packet_size(MAXIMUM_UDP_PACKET_SIZE);
180+
assert_eq!(cfg.packet_size(), MAXIMUM_UDP_PACKET_SIZE);
181+
}
182+
183+
#[test]
184+
fn set_yield_count_accepts_the_exact_minimum() {
185+
let mut cfg = LimitedUdpRelayConfig::default();
186+
cfg.set_yield_count(MINIMUM_UDP_RELAY_YIELD_COUNT);
187+
assert_eq!(cfg.yield_count, MINIMUM_UDP_RELAY_YIELD_COUNT);
188+
cfg.set_yield_count(0);
189+
assert_eq!(cfg.yield_count, MINIMUM_UDP_RELAY_YIELD_COUNT);
190+
}
191+
192+
#[test]
193+
fn config_copy_keeps_the_source_unchanged() {
194+
let mut cfg = LimitedUdpRelayConfig::default();
195+
cfg.set_packet_size(1200);
196+
let copied = cfg;
197+
cfg.set_packet_size(1300);
198+
assert_eq!(copied.packet_size(), 1200);
199+
assert_ne!(copied, cfg);
200+
}
144201
}

0 commit comments

Comments
 (0)