How to use `service_per_type`?

[merschformann]

Ahoi!

I can see that service on vroom.Job was split into default_service and service_per_type. While addressing the breaking change, I first did not notice default_service at first. So, I tried getting service_per_type working, which appears to be connected to the type on the vroom.Vehicle. However, no such type appears to be exposed (though, it's documented in the API docs - admittedly not the Python API docs).

E.g., this fails:

import vroom

stop = vroom.Job(
    id=0,
    location=0,
    service_per_type={"truck": 10},
)

vehicle = vroom.Vehicle(
    id=0,
    profile="truck",
    type="truck",
)

However, I might just be missing something. I just wanted to flag it as potentially misleading. 😊

[jonathf]

Agreed, that feature was missing.

I am releasing 1.15.1 now (within an hour) with support for the type argument in the Vehicle class. I am not using this feature, so pleasce let me know if it solves your issue.

[merschformann]

Thank you for the quick response and for addressing it! 🤗

I ended up not needing it, but I did test it to make sure it works as expected (as a replacement for default at least). ☺️

Updated on our side nevertheless nextmv-io/community-apps#191. I ran into another problem, but were able to contribute the fix myself, I think (#141).

[jcoupey]

While addressing the breaking change, I first did not notice default_service at first.

I did not look at the binding changes, but just to clarify on the upstream implementation, this is not intended as a breaking change: the legacy service key is the default, only possibly overridden by service_per_type values.

[merschformann]

While addressing the breaking change, I first did not notice default_service at first.

I did not look at the binding changes, but just to clarify on the upstream implementation, this is not intended as a breaking change: the legacy service key is the default, only possibly overridden by service_per_type values.

Makes sense. I was referring to the service attribute / parameter that is now called default_service. When addressing that breaking change (all fine, no biggie really), I just happened to stumble upon service_per_type before default_service. And that made me realize that I would need bindings for type on the vehicle too. 😊

Anyway, all fixed and working. Thanks for the quick reaction! ❤️