Skip to content

Commit fb663e5

Browse files
daiyamdaiyam
committed
fix: pass env variables as args
1 parent 457311f commit fb663e5

3 files changed

Lines changed: 14 additions & 8 deletions

File tree

‎.github/workflows/prebuilt-binaries-cross.yml‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,14 @@ jobs:
145145
- name: Verify binary architecture
146146
run: ./.github/scripts/linux/verify-elf.sh '${{ matrix.slug }}' build/Release/keymapping.node
147147
- name: Package artifact
148-
run: ./.github/scripts/package-tar.sh '${{ env.TARGET_PLATFORM }}' '${{ matrix.slug }}' '${PACKAGE_VERSION}'
148+
run: ./.github/scripts/package-tar.sh "${TARGET_PLATFORM}" '${{ matrix.slug }}' "${PACKAGE_VERSION}"
149149
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
150150
with:
151151
name: native-keymap-${{ env.TARGET_PLATFORM }}-${{ matrix.slug }}
152152
path: |
153153
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.slug }}.tar.gz
154154
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.slug }}.tar.gz.sha256
155+
if-no-files-found: error
155156

156157
macos-cross:
157158
name: macOS cross (${{ matrix.label }})
@@ -194,13 +195,14 @@ jobs:
194195
- name: Verify binary architecture
195196
run: ./.github/scripts/macos/verify-macho.sh '${{ matrix.label }}' build/Release/keymapping.node
196197
- name: Package artifact
197-
run: ./.github/scripts/package-tar.sh '${{ env.TARGET_PLATFORM }}' '${{ matrix.label }}' '${PACKAGE_VERSION}'
198+
run: ./.github/scripts/package-tar.sh "${TARGET_PLATFORM}" '${{ matrix.label }}' "${PACKAGE_VERSION}"
198199
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
199200
with:
200201
name: native-keymap-${{ env.TARGET_PLATFORM }}-${{ matrix.label }}
201202
path: |
202203
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.label }}.tar.gz
203204
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.label }}.tar.gz.sha256
205+
if-no-files-found: error
204206

205207
windows-cross:
206208
name: Windows cross (${{ matrix.arch }})
@@ -243,13 +245,14 @@ jobs:
243245
- name: Verify binary architecture
244246
run: ./.github/scripts/windows/verify-pe.sh '${{ matrix.arch }}' 'build/Release/keymapping.node'
245247
- name: Package artifact
246-
run: ./.github/scripts/package-tar.sh '${{ env.TARGET_PLATFORM }}' '${{ matrix.arch }}' '${PACKAGE_VERSION}'
248+
run: ./.github/scripts/package-tar.sh "${TARGET_PLATFORM}" '${{ matrix.arch }}' "${PACKAGE_VERSION}"
247249
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
248250
with:
249251
name: native-keymap-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}
250252
path: |
251253
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}.tar.gz
252254
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}.tar.gz.sha256
255+
if-no-files-found: error
253256

254257
publish:
255258
name: Publish Release

‎.github/workflows/prebuilt-binaries-host.yml‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,14 @@ jobs:
9696
- name: Verify binary architecture
9797
run: ./.github/scripts/linux/verify-elf.sh '${{ matrix.slug }}' build/Release/keymapping.node
9898
- name: Package artifact
99-
run: ./.github/scripts/package-tar.sh '${{ env.TARGET_PLATFORM }}' '${{ matrix.slug }}' '${PACKAGE_VERSION}'
99+
run: ./.github/scripts/package-tar.sh "${TARGET_PLATFORM}" '${{ matrix.slug }}' "${PACKAGE_VERSION}"
100100
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
101101
with:
102102
name: native-keymap-${{ env.TARGET_PLATFORM }}-${{ matrix.slug }}
103103
path: |
104104
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.slug }}.tar.gz
105105
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.slug }}.tar.gz.sha256
106+
if-no-files-found: error
106107

107108
macos:
108109
name: macOS (${{ matrix.arch }})
@@ -133,13 +134,14 @@ jobs:
133134
- name: Verify binary architecture
134135
run: ./.github/scripts/macos/verify-macho.sh '${{ matrix.arch }}' build/Release/keymapping.node
135136
- name: Package artifact
136-
run: ./.github/scripts/package-tar.sh '${{ env.TARGET_PLATFORM }}' '${{ matrix.arch }}' '${PACKAGE_VERSION}'
137+
run: ./.github/scripts/package-tar.sh "${TARGET_PLATFORM}" '${{ matrix.arch }}' "${PACKAGE_VERSION}"
137138
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
138139
with:
139140
name: native-keymap-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}
140141
path: |
141142
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}.tar.gz
142143
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}.tar.gz.sha256
144+
if-no-files-found: error
143145

144146
windows:
145147
name: Windows (${{ matrix.arch }})
@@ -174,13 +176,14 @@ jobs:
174176
- name: Verify binary architecture
175177
run: ./.github/scripts/windows/verify-pe.sh '${{ matrix.arch }}' 'build/Release/keymapping.node'
176178
- name: Package artifact
177-
run: ./.github/scripts/package-tar.sh '${{ env.TARGET_PLATFORM }}' '${{ matrix.arch }}' '${PACKAGE_VERSION}'
179+
run: ./.github/scripts/package-tar.sh "${TARGET_PLATFORM}" '${{ matrix.arch }}' "${PACKAGE_VERSION}"
178180
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
179181
with:
180182
name: native-keymap-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}
181183
path: |
182184
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}.tar.gz
183185
${{ env.PREBUILT_DIR }}/native-keymap-${{ env.PACKAGE_VERSION }}-${{ env.TARGET_PLATFORM }}-${{ matrix.arch }}.tar.gz.sha256
186+
if-no-files-found: error
184187

185188
publish:
186189
name: Publish Release

‎.github/zizmor.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ rules:
22
superfluous-actions:
33
ignore:
44
# allows `softprops/action-gh-release` action
5-
- prebuilt-binaries-cross.yml:286
6-
- prebuilt-binaries-host.yml:216
5+
- prebuilt-binaries-cross.yml:290
6+
- prebuilt-binaries-host.yml:220
77

0 commit comments

Comments
 (0)