Skip to content

Commit 3db4d59

Browse files
daiyamdaiyam
committed
ci: publish workflows are always deploying
1 parent 54162c1 commit 3db4d59

6 files changed

Lines changed: 38 additions & 67 deletions

‎.github/workflows/publish-insider-linux.yml‎

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
MS_TAG: ${{ env.MS_TAG }}
2929
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
3030
SHOULD_BUILD: ${{ env.SHOULD_BUILD }}
31-
SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }}
3231

3332
steps:
3433
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -113,7 +112,7 @@ jobs:
113112
with:
114113
name: vscode
115114
path: ./vscode.tar.gz
116-
retention-days: ${{ needs.check.outputs.SHOULD_DEPLOY == 'yes' && 30 || 1 }}
115+
retention-days: 30
117116
if: env.SHOULD_BUILD == 'yes'
118117

119118
build:
@@ -161,12 +160,10 @@ jobs:
161160
MS_TAG: ${{ needs.check.outputs.MS_TAG }}
162161
RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }}
163162
SHOULD_BUILD: ${{ needs.check.outputs.SHOULD_BUILD }}
164-
SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }}
165163
VSCODE_ARCH: ${{ matrix.vscode_arch }}
166164
outputs:
167165
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
168166
SHOULD_BUILD: ${{ env.SHOULD_BUILD }}
169-
SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }}
170167

171168
steps:
172169
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -177,7 +174,7 @@ jobs:
177174

178175
- name: Install GH
179176
run: ./build/linux/install_gh.sh
180-
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
177+
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes'
181178

182179
- name: Check existing VSCodium tags/releases
183180
env:
@@ -216,21 +213,21 @@ jobs:
216213
VSCODE_SYSROOT_VERSION: ${{ steps.build.outputs.VSCODE_SYSROOT_VERSION }}
217214
VSCODE_SYSROOT_PREFIX: ${{ steps.build.outputs.VSCODE_SYSROOT_PREFIX }}
218215
run: ./prepare_assets.sh
219-
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
216+
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes'
220217

221218
- name: Release
222219
env:
223220
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
224221
GITHUB_USERNAME: ${{ github.repository_owner }}
225222
run: ./release.sh
226-
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
223+
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes'
227224

228225
- name: Update versions repo
229226
env:
230227
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
231228
GITHUB_USERNAME: ${{ github.repository_owner }}
232229
run: ./update_version.sh
233-
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
230+
if: env.DISABLED != 'yes' && env.SHOULD_BUILD == 'yes'
234231

235232
reh_linux:
236233
needs:
@@ -272,7 +269,6 @@ jobs:
272269
MS_TAG: ${{ needs.check.outputs.MS_TAG }}
273270
RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }}
274271
SHOULD_BUILD: ${{ needs.check.outputs.SHOULD_BUILD }}
275-
SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }}
276272
VSCODE_ARCH: ${{ matrix.vscode_arch }}
277273
if: needs.check.outputs.SHOULD_BUILD == 'yes'
278274

@@ -308,7 +304,7 @@ jobs:
308304

309305
- name: Install GH
310306
run: ./build/linux/install_gh.sh
311-
if: env.DISABLED != 'yes' && env.SHOULD_DEPLOY == 'yes'
307+
if: env.DISABLED != 'yes'
312308

313309
- name: Check existing VSCodium tags/releases
314310
env:
@@ -335,7 +331,7 @@ jobs:
335331
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
336332
GITHUB_USERNAME: ${{ github.repository_owner }}
337333
run: ./release.sh
338-
if: env.DISABLED != 'yes' && env.SHOULD_DEPLOY == 'yes' && (env.SHOULD_BUILD_REH != 'no' || env.SHOULD_BUILD_REH_WEB != 'no')
334+
if: env.DISABLED != 'yes' && (env.SHOULD_BUILD_REH != 'no' || env.SHOULD_BUILD_REH_WEB != 'no')
339335

340336
reh_alpine:
341337
needs:
@@ -363,7 +359,6 @@ jobs:
363359
OS_NAME: alpine
364360
RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }}
365361
SHOULD_BUILD: ${{ needs.check.outputs.SHOULD_BUILD }}
366-
SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }}
367362
VSCODE_ARCH: ${{ matrix.vscode_arch }}
368363
if: needs.check.outputs.SHOULD_BUILD == 'yes'
369364

@@ -386,7 +381,6 @@ jobs:
386381

387382
- name: Install GH
388383
run: ./build/linux/install_gh.sh
389-
if: env.SHOULD_DEPLOY == 'yes'
390384

391385
- name: Check existing VSCodium tags/releases
392386
env:
@@ -416,7 +410,7 @@ jobs:
416410
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
417411
GITHUB_USERNAME: ${{ github.repository_owner }}
418412
run: ./release.sh
419-
if: env.DISABLED != 'yes' && env.SHOULD_DEPLOY == 'yes' && (env.SHOULD_BUILD_REH != 'no' || env.SHOULD_BUILD_REH_WEB != 'no')
413+
if: env.DISABLED != 'yes' && (env.SHOULD_BUILD_REH != 'no' || env.SHOULD_BUILD_REH_WEB != 'no')
420414

421415
aur:
422416
needs:
@@ -431,7 +425,6 @@ jobs:
431425
include:
432426
- package_name: vscodium-insiders-bin
433427
- package_name: vscodium-insiders
434-
if: needs.check.outputs.SHOULD_DEPLOY == 'yes'
435428

436429
steps:
437430
- name: Get version
@@ -465,7 +458,7 @@ jobs:
465458
platform:
466459
- amd64
467460
- arm64
468-
if: needs.check.outputs.SHOULD_DEPLOY == 'yes' && needs.check.outputs.SHOULD_BUILD_SNAP != 'no' && vars.DISABLE_INSIDER_SNAP != 'yes'
461+
if: needs.check.outputs.SHOULD_BUILD_SNAP != 'no' && vars.DISABLE_INSIDER_SNAP != 'yes'
469462

470463
steps:
471464
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -500,7 +493,6 @@ jobs:
500493
runs-on: ubuntu-latest
501494
environment: publish
502495
permissions: {}
503-
if: needs.check.outputs.SHOULD_DEPLOY == 'yes'
504496

505497
steps:
506498
- name: Trigger repository rebuild

‎.github/workflows/publish-insider-macos.yml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ jobs:
5858
env:
5959
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6060
run: . check_tags.sh
61-
if: env.SHOULD_DEPLOY == 'yes'
6261

6362
- name: Build
6463
env:
@@ -74,21 +73,21 @@ jobs:
7473
CERTIFICATE_OSX_P12_PASSWORD: ${{ secrets.CERTIFICATE_OSX_NEW_P12_PASSWORD }}
7574
CERTIFICATE_OSX_TEAM_ID: ${{ secrets.CERTIFICATE_OSX_NEW_TEAM_ID }}
7675
run: ./prepare_assets.sh
77-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
76+
if: env.SHOULD_BUILD == 'yes'
7877

7978
- name: Release
8079
env:
8180
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
8281
GITHUB_USERNAME: ${{ github.repository_owner }}
8382
run: ./release.sh
84-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
83+
if: env.SHOULD_BUILD == 'yes'
8584

8685
- name: Update versions repo
8786
env:
8887
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
8988
GITHUB_USERNAME: ${{ github.repository_owner }}
9089
run: ./update_version.sh
91-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
90+
if: env.SHOULD_BUILD == 'yes'
9291

9392
- name: Clean up keychain
9493
if: always()

‎.github/workflows/publish-insider-windows.yml‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
MS_TAG: ${{ env.MS_TAG }}
2727
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
2828
SHOULD_BUILD: ${{ env.SHOULD_BUILD }}
29-
SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }}
3029

3130
steps:
3231
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -103,7 +102,7 @@ jobs:
103102
with:
104103
name: vscode
105104
path: ./vscode.tar.gz
106-
retention-days: ${{ needs.check.outputs.SHOULD_DEPLOY == 'yes' && 30 || 1 }}
105+
retention-days: 30
107106
if: env.SHOULD_BUILD == 'yes'
108107

109108
build:
@@ -129,11 +128,9 @@ jobs:
129128
MS_TAG: ${{ needs.check.outputs.MS_TAG }}
130129
RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }}
131130
SHOULD_BUILD: ${{ needs.check.outputs.SHOULD_BUILD }}
132-
SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }}
133131
VSCODE_ARCH: ${{ matrix.vscode_arch }}
134132
outputs:
135133
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
136-
SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }}
137134

138135
steps:
139136
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -177,7 +174,7 @@ jobs:
177174

178175
- name: Prepare assets
179176
run: ./prepare_assets.sh
180-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
177+
if: env.SHOULD_BUILD == 'yes'
181178

182179
- name: Upload unsigned artifacts
183180
id: upload-unsigned-artifacts
@@ -188,7 +185,7 @@ jobs:
188185
assets/*.exe
189186
assets/*.msi
190187
retention-days: 1
191-
if: env.SHOULD_BUILD == 'yes' && vars.DISABLE_INSIDER_WINDOWS_SIGNING != 'yes' && env.SHOULD_DEPLOY == 'yes'
188+
if: env.SHOULD_BUILD == 'yes' && vars.DISABLE_INSIDER_WINDOWS_SIGNING != 'yes'
192189

193190
- name: Signing
194191
uses: signpath/github-action-submit-signing-request@b9d91eadd323de506c0c81cf0c7fe7438f3360fd # v2.2
@@ -203,25 +200,25 @@ jobs:
203200
# 3h to manually approve the request
204201
wait-for-completion-timeout-in-seconds: 28800
205202
output-artifact-directory: assets/
206-
if: env.SHOULD_BUILD == 'yes' && vars.DISABLE_INSIDER_WINDOWS_SIGNING != 'yes' && env.SHOULD_DEPLOY == 'yes'
203+
if: env.SHOULD_BUILD == 'yes' && vars.DISABLE_INSIDER_WINDOWS_SIGNING != 'yes'
207204

208205
- name: Prepare checksums
209206
run: ./prepare_checksums.sh
210-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
207+
if: env.SHOULD_BUILD == 'yes'
211208

212209
- name: Release
213210
env:
214211
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
215212
GITHUB_USERNAME: ${{ github.repository_owner }}
216213
run: ./release.sh
217-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
214+
if: env.SHOULD_BUILD == 'yes'
218215

219216
- name: Update versions repo
220217
env:
221218
GITHUB_TOKEN: ${{ secrets.STRONGER_GITHUB_TOKEN }}
222219
GITHUB_USERNAME: ${{ github.repository_owner }}
223220
run: ./update_version.sh
224-
if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes'
221+
if: env.SHOULD_BUILD == 'yes'
225222

226223
winget:
227224
needs: build
@@ -235,7 +232,6 @@ jobs:
235232
env:
236233
APP_IDENTIFIER: VSCodium.VSCodium.Insiders
237234
ASSETS_REPOSITORY: vscodium-insiders
238-
if: needs.build.outputs.SHOULD_DEPLOY == 'yes'
239235

240236
steps:
241237
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

0 commit comments

Comments
 (0)