style: use ecformat to lint project (#2905)

Author: BaumiCoder

.ecformat_ignore

@@ -0,0 +1,12 @@
+# Binary files
+*.bmp
+*.icns
+*.ico
+*.png
+*.xpm
+
+# File types with a mixed formatting which seems to be intentional.
+# Disabling only check for some properties (like indent_size) is currently not supported.
+
+# Some mixed indentation due to alignment with previous line
+stores/snapcraft/{stable,insider}/snap/local/bin/electron-launch

.editorconfig

@@ -9,17 +9,29 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
+[*.md]
+indent_style = space
+indent_size = 3
+
+[*.patch{,.no,.yet}]
+trim_trailing_whitespace = false
+insert_final_newline = false
+# There are files with different kinds of indentations
+indent_style = unset
+indent_size = unset
+
 [*.sh]
 indent_style = space
 indent_size = 2
 
+[*.svg]
+insert_final_newline = false
+
 [*.{yml,yaml}]
 indent_style = space
 indent_size = 2
 
-[*.patch]
-trim_trailing_whitespace = false
-insert_final_newline = false
-
-[*.svg]
-insert_final_newline = false
+[*.{xml,xsl,wxi,wxl,wxs}]
+indent_style = tab
+indent_size = 4
+tab_width = 4

.github/ISSUE_TEMPLATE/bug_report.md

@@ -30,11 +30,11 @@ A clear and concise description of what you expected to happen.
 If applicable, add screenshots to help explain your problem.
 
 **Desktop (please complete the following information):**
- - OS: [e.g. Mac OS, Ubuntu 20.04, etc]
- - Architecture [e.g. x64, ia32, arm64]
- - Version [e.g. 1.33.0]
- - App Manager [e.g. Winget, Homebrew, Snap, AUR, RPM, Nix, ...]
- - Sandboxed [e.g. no, Flatpak, Snap]
+- OS: [e.g. Mac OS, Ubuntu 20.04, etc]
+- Architecture [e.g. x64, ia32, arm64]
+- Version [e.g. 1.33.0]
+- App Manager [e.g. Winget, Homebrew, Snap, AUR, RPM, Nix, ...]
+- Sandboxed [e.g. no, Flatpak, Snap]
 
 **Additional context**
 Add any other context about the problem here.

.github/workflows/lint-ecformat.yml

@@ -0,0 +1,29 @@
+name: Lint - ecformat
+
+on:
+  push:
+    branches:
+      - master
+      - insider
+  pull_request:
+    branches:
+      - "**"
+
+permissions: {}
+
+jobs:
+  ecformat:
+    runs-on: ubuntu-latest
+    permissions:
+      security-events: write
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+
+      - name: Run ecformat
+        run: |
+          cargo install ecformat@0.2.0
+
+          ecformat check --verbose --ignore-file .ecformat_ignore

CODE_OF_CONDUCT.md

@@ -21,20 +21,20 @@ community include:
 * Being respectful of differing opinions, viewpoints, and experiences
 * Giving and gracefully accepting constructive feedback
 * Accepting responsibility and apologizing to those affected by our mistakes,
-  and learning from the experience
+   and learning from the experience
 * Focusing on what is best not just for us as individuals, but for the overall
-  community
+   community
 
 Examples of unacceptable behavior include:
 
 * The use of sexualized language or imagery, and sexual attention or advances of
-  any kind
+   any kind
 * Trolling, insulting or derogatory comments, and personal or political attacks
 * Public or private harassment
 * Publishing others' private information, such as a physical or email address,
-  without their explicit permission
+   without their explicit permission
 * Other conduct which could reasonably be considered inappropriate in a
-  professional setting
+   professional setting
 
 ## Enforcement Responsibilities
 

LICENSE

@@ -20,4 +20,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+SOFTWARE.

README.md

@@ -1,8 +1,8 @@
 <div id="vscodium-logo" align="center">
-    <br />
-    <img src="./icons/stable/codium_cnl.svg" alt="VSCodium Logo" width="200"/>
-    <h1>VSCodium</h1>
-    <h3>Free/Libre Open Source Software Binaries of Visual Studio Code</h3>
+   <br />
+   <img src="./icons/stable/codium_cnl.svg" alt="VSCodium Logo" width="200"/>
+   <h1>VSCodium</h1>
+   <h3>Free/Libre Open Source Software Binaries of Visual Studio Code</h3>
 </div>
 
 <div id="badges" align="center">
@@ -20,14 +20,14 @@
 ## Table of Contents
 
 - [Download/Install](#download-install)
-  - [Install with Brew](#install-with-brew)
-  - [Install with Windows Package Manager (WinGet)](#install-with-winget)
-  - [Install with Chocolatey](#install-with-choco)
-  - [Install with Scoop](#install-with-scoop)
-  - [Install with snap](#install-with-snap)
-  - [Install with Package Manager](#install-with-package-manager)
-  - [Install on Arch Linux](#install-on-arch-linux)
-  - [Flatpak Option](#flatpak)
+   - [Install with Brew](#install-with-brew)
+   - [Install with Windows Package Manager (WinGet)](#install-with-winget)
+   - [Install with Chocolatey](#install-with-choco)
+   - [Install with Scoop](#install-with-scoop)
+   - [Install with snap](#install-with-snap)
+   - [Install with Package Manager](#install-with-package-manager)
+   - [Install on Arch Linux](#install-on-arch-linux)
+   - [Flatpak Option](#flatpak)
 - [Build](#build)
 - [Why Does This Exist](#why)
 - [More Info](#more-info)
@@ -143,12 +143,12 @@ If you want to build from source yourself, head over to [Microsoft's vscode repo
 Microsoft's build process (which we are running to build the binaries) does download additional files. Those packages downloaded during build are:
 
 - Pre-built extensions from the GitHub:
-  - [ms-vscode.js-debug-companion](https://github.com/microsoft/vscode-js-debug-companion)
-  - [ms-vscode.js-debug](https://github.com/microsoft/vscode-js-debug)
-  - [ms-vscode.vscode-js-profile-table](https://github.com/microsoft/vscode-js-profile-visualizer)
+   - [ms-vscode.js-debug-companion](https://github.com/microsoft/vscode-js-debug-companion)
+   - [ms-vscode.js-debug](https://github.com/microsoft/vscode-js-debug)
+   - [ms-vscode.vscode-js-profile-table](https://github.com/microsoft/vscode-js-profile-visualizer)
 - From [Electron releases](https://github.com/electron/electron/releases) (using [gulp-atom-electron](https://github.com/joaomoreno/gulp-atom-electron))
-  - electron
-  - ffmpeg
+   - electron
+   - ffmpeg
 
 ## <a id="more-info"></a>More Info
 
@@ -189,32 +189,32 @@ The minimal version is limited by the core component Electron, you may want to c
 ## <a id="previously-supported-platforms"></a>Previously Supported Platforms
 
 - GNU/Linux armhf:
-  - Latest available: [v1.121.03429](https://github.com/VSCodium/vscodium/releases/tag/1.121.03429).
-  - Breaking point: `node-v24`.
+   - Latest available: [v1.121.03429](https://github.com/VSCodium/vscodium/releases/tag/1.121.03429).
+   - Breaking point: `node-v24`.
 
 ## <a id="thanks"></a>Special thanks
 
 <table>
-  <tr>
-    <td><a href="https://github.com/jaredreich" target="_blank">@jaredreich</a></td>
-    <td>for the logo</td>
-  </tr>
-  <tr>
-    <td><a href="https://github.com/PalinuroSec" target="_blank">@PalinuroSec</a></td>
-    <td>for CDN and domain name</td>
-  </tr>
-  <tr>
-    <td><a href="https://www.macstadium.com" target="_blank"><img src="https://images.prismic.io/macstadium/66fbce64-707e-41f3-b547-241908884716_MacStadium_Logo.png?w=128&q=75" width="128" height="49" alt="MacStadium logo" /></a></td>
-    <td>for providing a Mac mini M1</td>
-  </tr>
-  <tr>
-    <td><a href="https://github.com/daiyam" target="_blank">@daiyam</a></td>
-    <td>for macOS certificate</td>
-  </tr>
-  <tr>
-    <td><a href="https://signpath.org/" target="_blank"><img src="https://avatars.githubusercontent.com/u/34448643" height="30" alt="SignPath logo" /></a></td>
-    <td>free code signing on Windows provided by <a href="https://signpath.io/" target="_blank">SignPath.io</a>, certificate by <a href="https://signpath.org/" target="_blank">SignPath Foundation</a></td>
-  </tr>
+   <tr>
+      <td><a href="https://github.com/jaredreich" target="_blank">@jaredreich</a></td>
+      <td>for the logo</td>
+   </tr>
+   <tr>
+      <td><a href="https://github.com/PalinuroSec" target="_blank">@PalinuroSec</a></td>
+      <td>for CDN and domain name</td>
+   </tr>
+   <tr>
+      <td><a href="https://www.macstadium.com" target="_blank"><img src="https://images.prismic.io/macstadium/66fbce64-707e-41f3-b547-241908884716_MacStadium_Logo.png?w=128&q=75" width="128" height="49" alt="MacStadium logo" /></a></td>
+      <td>for providing a Mac mini M1</td>
+   </tr>
+   <tr>
+      <td><a href="https://github.com/daiyam" target="_blank">@daiyam</a></td>
+      <td>for macOS certificate</td>
+   </tr>
+   <tr>
+      <td><a href="https://signpath.org/" target="_blank"><img src="https://avatars.githubusercontent.com/u/34448643" height="30" alt="SignPath logo" /></a></td>
+      <td>free code signing on Windows provided by <a href="https://signpath.io/" target="_blank">SignPath.io</a>, certificate by <a href="https://signpath.org/" target="_blank">SignPath Foundation</a></td>
+   </tr>
 </table>
 
 ## <a id="license"></a>License

build/linux/anylinux-appimage/cli-router.hook

@@ -2,50 +2,50 @@
 
 # when run in remote terminal, use the remote cli
 if [ -n "$VSCODE_IPC_HOOK_CLI" ]; then
-	REMOTE_CLI=""
-	_IFS=$IFS
-	IFS=:
-	for d in $PATH; do
-		case "$d" in
-			*/remote-cli/*)
-				if REMOTE_CLI=$(PATH=$d command -v @@NAME@@); then
-					break
-				fi
-				;;
-		esac
-	done
-	IFS=$_IFS
-	if [ -n "$REMOTE_CLI" ]; then
-		"$REMOTE_CLI" "$@"
-		exit $?
-	fi
+  REMOTE_CLI=""
+  _IFS=$IFS
+  IFS=:
+  for d in $PATH; do
+    case "$d" in
+      */remote-cli/*)
+        if REMOTE_CLI=$(PATH=$d command -v @@NAME@@); then
+          break
+        fi
+        ;;
+    esac
+  done
+  IFS=$_IFS
+  if [ -n "$REMOTE_CLI" ]; then
+    "$REMOTE_CLI" "$@"
+    exit $?
+  fi
 fi
 
 # test that @@NAME_LONG@@ wasn't installed inside WSL
 if grep -qi Microsoft /proc/version && [ -z "$DONT_PROMPT_WSL_INSTALL" ]; then
-	echo "To use @@NAME_LONG@@ with the Windows Subsystem for Linux, please install @@NAME_LONG@@ in Windows and uninstall the Linux version in WSL. You can then use the \`@@NAME@@\` command in a WSL terminal just as you would in a normal command prompt." 1>&2
-	printf "Do you want to continue anyway? [y/N] " 1>&2
-	read -r YN
-	case "$YN" in
-		y|Y|yes|Yes|YES) :;;
-		*) exit 1;;
-	esac
-	echo "To no longer see this prompt, start @@NAME_LONG@@ with the environment variable DONT_PROMPT_WSL_INSTALL defined." 1>&2
+  echo "To use @@NAME_LONG@@ with the Windows Subsystem for Linux, please install @@NAME_LONG@@ in Windows and uninstall the Linux version in WSL. You can then use the \`@@NAME@@\` command in a WSL terminal just as you would in a normal command prompt." 1>&2
+  printf "Do you want to continue anyway? [y/N] " 1>&2
+  read -r YN
+  case "$YN" in
+    y|Y|yes|Yes|YES) :;;
+    *) exit 1;;
+  esac
+  echo "To no longer see this prompt, start @@NAME_LONG@@ with the environment variable DONT_PROMPT_WSL_INSTALL defined." 1>&2
 fi
 
 # If root, ensure that --user-data-dir or --file-write is specified
 if [ "$APPIMAGE_UID" = 0 ]; then
-	for i do
-		case "$i" in
-			--user-data-dir|--user-data-dir=*|--file-write|tunnel|serve-web)
-				CAN_LAUNCH_AS_ROOT=1
-				;;
-		esac
-	done
-	if [ -z "$CAN_LAUNCH_AS_ROOT" ]; then
-		echo "You are trying to start @@NAME_LONG@@ as a super user which isn't recommended. If this was intended, please add the argument \`--no-sandbox\` and specify an alternate user data directory using the \`--user-data-dir\` argument." 1>&2
-		exit 1
-	fi
+  for i do
+    case "$i" in
+      --user-data-dir|--user-data-dir=*|--file-write|tunnel|serve-web)
+        CAN_LAUNCH_AS_ROOT=1
+        ;;
+    esac
+  done
+  if [ -z "$CAN_LAUNCH_AS_ROOT" ]; then
+    echo "You are trying to start @@NAME_LONG@@ as a super user which isn't recommended. If this was intended, please add the argument \`--no-sandbox\` and specify an alternate user data directory using the \`--user-data-dir\` argument." 1>&2
+    exit 1
+  fi
 fi
 
 ELECTRON=$APPDIR/bin/@@NAME@@

build/linux/ppc64le/electron.sha256sums

@@ -8,4 +8,4 @@ e246066ccc328729e6a9f2a0d829bc893391cf54ed199b809bb7e47993fed88f *electron.d.ts
 3e85df4843497ce567ad36ddf826cd1af7dfe9f883daad4623736ddd012dbfd1 *libcxx-objects-v41.0.3-linux-ppc64le.zip
 5587472eeaf9bfb76d0f187ecc19d11d60bc05f5e7c8fa822f2370210c30b95d *libcxx_headers.zip
 f531ddd2782b4b19caf622c0355c93892965e22861279cc891675230c1310905 *libcxxabi_headers.zip
-6cb0e67dc5a23de0ebbe89253e1f24bf9d4ca41213a1b9f784f2afaa2cf61324 *mksnapshot-v41.0.3-linux-ppc64le.zip
+6cb0e67dc5a23de0ebbe89253e1f24bf9d4ca41213a1b9f784f2afaa2cf61324 *mksnapshot-v41.0.3-linux-ppc64le.zip

build/windows/msi/build.sh

@@ -35,15 +35,15 @@ LICENSE_DIR="..\\..\\..\\vscode"
 PROGRAM_FILES_86=$( env | sed -n 's/^ProgramFiles(x86)=//p' )
 
 if [[ -z "${1}" ]]; then
-	OUTPUT_BASE_FILENAME="VSCodium-${VSCODE_ARCH}-${RELEASE_VERSION}"
+  OUTPUT_BASE_FILENAME="VSCodium-${VSCODE_ARCH}-${RELEASE_VERSION}"
 else
-	OUTPUT_BASE_FILENAME="VSCodium-${VSCODE_ARCH}-${1}-${RELEASE_VERSION}"
+  OUTPUT_BASE_FILENAME="VSCodium-${VSCODE_ARCH}-${1}-${RELEASE_VERSION}"
 fi
 
 if [[ "${VSCODE_ARCH}" == "ia32" ]]; then
-   export PLATFORM="x86"
+  export PLATFORM="x86"
 else
-   export PLATFORM="${VSCODE_ARCH}"
+  export PLATFORM="${VSCODE_ARCH}"
 fi
 
 sed -i "s|@@PRODUCT_UPGRADE_CODE@@|${PRODUCT_UPGRADE_CODE}|g" .\\includes\\vscodium-variables.wxi
@@ -52,25 +52,25 @@ sed -i "s|@@PRODUCT_NAME@@|${PRODUCT_NAME}|g" .\\vscodium.xsl
 find i18n -name '*.wxl' -print0 | xargs -0 sed -i "s|@@PRODUCT_NAME@@|${PRODUCT_NAME}|g"
 
 BuildSetupTranslationTransform() {
-	local CULTURE=${1}
-	local LANGID=${2}
+  local CULTURE=${1}
+  local LANGID=${2}
 
-	LANGIDS="${LANGIDS},${LANGID}"
+  LANGIDS="${LANGIDS},${LANGID}"
 
-	echo "Building setup translation for culture \"${CULTURE}\" with LangID \"${LANGID}\"..."
+  echo "Building setup translation for culture \"${CULTURE}\" with LangID \"${LANGID}\"..."
 
-	"${WIX}bin\\light.exe" vscodium.wixobj "Files-${OUTPUT_BASE_FILENAME}.wixobj" -ext WixUIExtension -ext WixUtilExtension -ext WixNetFxExtension -spdb -cc "${TEMP}\\vscodium-cab-cache\\${PLATFORM}" -reusecab -out "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi" -loc "i18n\\vscodium.${CULTURE}.wxl" -cultures:"${CULTURE}" -sice:ICE60 -sice:ICE69
+  "${WIX}bin\\light.exe" vscodium.wixobj "Files-${OUTPUT_BASE_FILENAME}.wixobj" -ext WixUIExtension -ext WixUtilExtension -ext WixNetFxExtension -spdb -cc "${TEMP}\\vscodium-cab-cache\\${PLATFORM}" -reusecab -out "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi" -loc "i18n\\vscodium.${CULTURE}.wxl" -cultures:"${CULTURE}" -sice:ICE60 -sice:ICE69
 
-	cscript "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\${PLATFORM}\\WiLangId.vbs" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi" Product "${LANGID}"
+  cscript "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\${PLATFORM}\\WiLangId.vbs" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi" Product "${LANGID}"
 
-	"${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\x86\\msitran" -g "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.msi" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.mst"
+  "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\x86\\msitran" -g "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.msi" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.mst"
 
-	cscript "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\${PLATFORM}\\wisubstg.vbs" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.msi" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.mst" "${LANGID}"
+  cscript "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\${PLATFORM}\\wisubstg.vbs" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.msi" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.mst" "${LANGID}"
 
-	cscript "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\${PLATFORM}\\wisubstg.vbs" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.msi"
+  cscript "${PROGRAM_FILES_86}\\Windows Kits\\${WIN_SDK_MAJOR_VERSION}\\bin\\${WIN_SDK_FULL_VERSION}\\${PLATFORM}\\wisubstg.vbs" "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.msi"
 
-	rm -f "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi"
-	rm -f "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.mst"
+  rm -f "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.msi"
+  rm -f "${SETUP_RELEASE_DIR}\\${OUTPUT_BASE_FILENAME}.${CULTURE}.mst"
 }
 
 "${WIX}bin\\heat.exe" dir "${BINARY_DIR}" -out "Files-${OUTPUT_BASE_FILENAME}.wxs" -t vscodium.xsl -gg -sfrag -scom -sreg -srd -ke -cg "AppFiles" -var var.ManufacturerName -var var.AppName -var var.AppCodeName -var var.ProductVersion -var var.IconDir -var var.LicenseDir -var var.BinaryDir -dr APPLICATIONFOLDER -platform "${PLATFORM}"