Skip to content

Commit 4e09408

Browse files
committed
test(fft): Use 1D grid notation for FFT basic tests
Changed from single-value initializers {N} to proper 1D grid format {N, 1, 1} for GridSize, PhysicalOrigin, and GridSpacing. This ensures all three dimensions are explicitly initialized. Single-value initializers like GridSpacing({1}) only set the first dimension, leaving y=0 and z=0, which fails coordinate system validation requiring spacing > 0 in all dimensions. Fixed in three test cases: - FFT basic functionality: {8, 1, 1} - FFT forward transformation: {8, 1, 1} - FFT backward transformation: {2, 1, 1} Fixes "Spacing must be positive" test failures.
1 parent 8b277f1 commit 4e09408

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/unit/fft/test_fft.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ using namespace Catch::Matchers;
1515
using namespace pfc;
1616

1717
TEST_CASE("FFT - basic functionality", "[fft][unit]") {
18-
auto world = world::create(GridSize({8}), PhysicalOrigin({1}), GridSpacing({1}));
18+
auto world = world::create(GridSize({8, 1, 1}), PhysicalOrigin({1.0, 1.0, 1.0}),
19+
GridSpacing({1.0, 1.0, 1.0}));
1920
auto decomposition = decomposition::create(world, 1);
2021
auto fft = fft::create(decomposition);
2122
REQUIRE(fft.size_inbox() > 0);
@@ -25,7 +26,8 @@ TEST_CASE("FFT - basic functionality", "[fft][unit]") {
2526

2627
TEST_CASE("FFT - forward transformation", "[fft][unit]") {
2728
// Create an FFT object with a fixed decomposition
28-
auto world = world::create(GridSize({8}), PhysicalOrigin({1}), GridSpacing({1}));
29+
auto world = world::create(GridSize({8, 1, 1}), PhysicalOrigin({1.0, 1.0, 1.0}),
30+
GridSpacing({1.0, 1.0, 1.0}));
2931
auto decomposition = decomposition::create(world, 1);
3032
auto fft = fft::create(decomposition);
3133

@@ -46,7 +48,8 @@ TEST_CASE("FFT - forward transformation", "[fft][unit]") {
4648

4749
TEST_CASE("FFT - backward transformation", "[fft][unit]") {
4850
// Create an FFT object with a fixed decomposition
49-
auto world = world::create(GridSize({2}), PhysicalOrigin({1}), GridSpacing({1}));
51+
auto world = world::create(GridSize({2, 1, 1}), PhysicalOrigin({1.0, 1.0, 1.0}),
52+
GridSpacing({1.0, 1.0, 1.0}));
5053
auto decomposition = decomposition::create(world, 1);
5154
auto fft = fft::create(decomposition);
5255

0 commit comments

Comments
 (0)