Skip to content

Commit 12ab1f3

Browse files
CopilotVaiz
andcommitted
Move copilot instructions to .github/ and address review feedback
Co-authored-by: Vaiz <4908982+Vaiz@users.noreply.github.com>
1 parent d1cc43e commit 12ab1f3

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,13 @@ When working on code changes:
7777
1. **Check current state**: Use `Rust-cargo-check` with `workspace: true`
7878
2. **Make changes**: Edit code using appropriate tools
7979
3. **Validate**: Use `Rust-cargo-clippy` with `workspace: true, all_targets: true`
80-
4. **Format**: Use `Rust-cargo-fmt` with `all: true`
80+
4. **Format**: Use `Rust-cargo-fmt` with `all: true` (requires nightly toolchain)
8181
5. **Test**: Use `Rust-cargo-test` with `workspace: true, all_features: true`
8282
6. **Build**: Use `Rust-cargo-build` with `workspace: true` for final verification
8383

8484
### 3. Dependency Management
8585

86-
- Always use `Rust-cargo-machete` to check for unused dependencies before adding new ones
86+
- Always use `Rust-cargo-machete` to check for unused dependencies before adding new ones (may require installing tools first)
8787
- Use `Rust-cargo-deny-check` to verify security and compliance
8888
- When adding dependencies, prefer workspace-level dependencies in the root `Cargo.toml`
8989

@@ -137,12 +137,7 @@ This project implements the NFS3 protocol in Rust with the following key compone
137137
- `crates/nfs3_client/src/lib.rs`: Client API
138138
- `crates/nfs3_tests/src/`: Integration test suites
139139

140-
### Common Issues and Solutions
141140

142-
1. **Lifetime Annotations**: This project uses extensive lifetime annotations for zero-copy operations
143-
2. **Async/Await**: All I/O operations are async and use tokio
144-
3. **RPC Serialization**: Custom XDR serialization for NFS3 protocol
145-
4. **Cross-Platform**: Code must work on Windows, Linux, and macOS
146141

147142
## Toolchain Requirements
148143

0 commit comments

Comments
 (0)