fix: cleanup

Author: neocybereth

.github/actions/prepare-build/action.yml

@@ -11,6 +11,10 @@ runs:
       with:
         cache-name: build
 
+    - name: Setup Rust toolchain
+      run: rustup toolchain add nightly-2025-03-27
+      shell: bash
+
     - name: Install protoc
       run: sudo apt-get install -y protobuf-compiler
       shell: bash

.github/actions/release-project/action.yml

@@ -30,13 +30,3 @@ runs:
         zip -r ${{ inputs.bundle_filename }} .
         gh release upload ${{ inputs.tag }} ${{ inputs.bundle_filename }}
       shell: bash
-
-    - name: Merge main branch into stable
-      run: |
-        git config --global user.name "github-actions[bot]"
-        git config --global user.email "github-actions[bot]@users.noreply.github.com"
-        git fetch
-        git checkout stable-interface
-        git merge origin/main --no-edit
-        git push origin stable-interface
-      shell: bash

.github/workflows/docker.yml

@@ -3,10 +3,11 @@ name: Docker Namadillo 🐳
 on:
   push:
     tags:
-      - namadillo@v*
+      - 'namadillo@v*'
     branches:
       - main
       - stable-interface
+  workflow_dispatch:
 
 env:
   GIT_LFS_SKIP_SMUDGE: 1

.release-please-manifest.json

@@ -1,6 +1,6 @@
 {
-  "apps/namadillo": "1.20.1",
-  "apps/extension": "0.5.0",
-  "packages/sdk": "0.18.1",
-  "packages/types": "0.6.0"
+  "apps/namadillo": "1.28.2",
+  "apps/extension": "0.8.1",
+  "packages/sdk": "0.19.1",
+  "packages/types": "0.7.0"
 }

apps/extension/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## [0.8.1](https://github.com/anoma/namada-interface/compare/extension@v0.8.0...extension@v0.8.1) (2025-06-19)
+
+
+### Bug Fixes
+
+* Extension sliced address ([#2169](https://github.com/anoma/namada-interface/issues/2169)) ([901cdfa](https://github.com/anoma/namada-interface/commit/901cdfaab5bf496537a69ee96cfe4fb7c69cb5a8))
+* Use correct derivation path for masp signs using ledger AND sign all sapling inputs ([#2163](https://github.com/anoma/namada-interface/issues/2163)) ([96539ed](https://github.com/anoma/namada-interface/commit/96539ed2f9e06752e7cb595ab9029e5237c46c1b))
+
+## [0.8.0](https://github.com/anoma/namada-interface/compare/extension@v0.7.0...extension@v0.8.0) (2025-06-10)
+
+
+### Features
+
+* Keychain - Increase session timeout from 5 to 30 minutes ([#2122](https://github.com/anoma/namada-interface/issues/2122)) ([243c013](https://github.com/anoma/namada-interface/commit/243c013356059cc7723b39ff2d60265b57b35cd1))
+
+## [0.7.0](https://github.com/anoma/namada-interface/compare/extension@v0.6.0...extension@v0.7.0) (2025-06-07)
+
+
+### Features
+
+* Mark Ledger accounts missing shielded account as outdated ([#2099](https://github.com/anoma/namada-interface/issues/2099)) ([ddb2f5c](https://github.com/anoma/namada-interface/commit/ddb2f5cb568a20a8dc94110ec81adf59d39e2f78))
+
 ## [0.6.0](https://github.com/anoma/namada-interface/compare/extension@v0.5.0...extension@v0.6.0) (2025-04-18)
 
 

apps/extension/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@namada/extension",
-  "version": "0.6.0",
+  "version": "0.8.1",
   "description": "Namada Keychain",
   "repository": "https://github.com/anoma/namada-interface/",
   "author": "Heliax Dev <info@heliax.dev>",

apps/extension/src/App/Accounts/ParentAccounts.tsx

@@ -53,6 +53,20 @@ export const ParentAccounts = (): JSX.Element => {
       }
     });
 
+  // We check whether a Ledger parent has an associated shielded account
+  allAccounts
+    .filter(
+      (account) => !account.parentId && account.type === AccountType.Ledger
+    )
+    .forEach(({ id }) => {
+      const shieldedAccount = allAccounts.find(
+        ({ parentId }) => parentId === id
+      );
+      if (!shieldedAccount) {
+        allParentAccounts[id]["outdated"] = true;
+      }
+    });
+
   const accounts = Object.values(allParentAccounts);
 
   useEffect(() => {

apps/extension/src/App/Accounts/UpdateRequired.tsx

@@ -71,7 +71,8 @@ export const UpdateRequired = (): JSX.Element => {
                 </li>
                 <li>Delete the marked account from 
the keychain</li>
                 <li>
-                  Re-Import the account using your seed phrase / private key
+                  Re-Import the account using your seed phrase / private key /
+                  Ledger HW wallet
                 </li>
               </ol>
             </Stack>

apps/extension/src/App/Accounts/ViewAccount.tsx

@@ -128,7 +128,7 @@ export const ViewAccount = (): JSX.Element => {
               transparentAccountPath={transparentPath}
               shieldedAccountAddress={shieldedAccount?.address}
               shieldedAccountPath={shieldedPath}
-              trimCharacters={21}
+              trimCharacters={16}
             />
             {viewingKey && (
               <>

apps/extension/src/Approvals/ConfirmSignLedgerTx.tsx

@@ -1,3 +1,5 @@
+import { getSdk } from "@namada/sdk/web";
+import sdkInit from "@namada/sdk/web-init";
 import clsx from "clsx";
 import { ReactNode, useCallback, useEffect, useState } from "react";
 
@@ -84,8 +86,9 @@ export const ConfirmSignLedgerTx: React.FC<Props> = ({ details }) => {
   const signMaspTx = async (
     ledger: Ledger,
     bytes: Uint8Array,
-    path: string
-  ): Promise<{ sbar: Uint8Array; rbar: Uint8Array }> => {
+    path: string,
+    shieldedHash?: string
+  ): Promise<{ sbar: Uint8Array; rbar: Uint8Array }[]> => {
     const signMaspSpendsResponse = await ledger.namadaApp.signMaspSpends(
       path,
       Buffer.from(bytes)
@@ -97,14 +100,36 @@ export const ConfirmSignLedgerTx: React.FC<Props> = ({ details }) => {
       );
     }
 
-    const spendSignatureResponse = await ledger.namadaApp.getSpendSignature();
-    if (spendSignatureResponse.returnCode !== LedgerError.NoErrors) {
-      throw new Error(
-        `Getting spends signature error encountered: ${signMaspSpendsResponse.errorMessage}`
-      );
+    if (!shieldedHash) {
+      throw new Error("Shielded hash is required for MASP transactions");
     }
 
-    return spendSignatureResponse;
+    const { cryptoMemory } = await sdkInit();
+    // TODO: Find a better way to init the sdk, token has to be any valid token
+    const sdk = getSdk(
+      cryptoMemory,
+      "",
+      "",
+      "",
+      "tnam1q9gr66cvu4hrzm0sd5kmlnjje82gs3xlfg3v6nu7"
+    );
+    const descriptors = await sdk
+      .getMasp()
+      .getDescriptorMap(bytes, fromBase64(shieldedHash));
+
+    const responses = [];
+    // TODO: this probably means that we do not really need descriptor map, but just to iterate over the sapling inputs
+    for (const _ of descriptors) {
+      const spendSignatureResponse = await ledger.namadaApp.getSpendSignature();
+      if (spendSignatureResponse.returnCode !== LedgerError.NoErrors) {
+        throw new Error(
+          `Getting spends signature error encountered: ${signMaspSpendsResponse.errorMessage}`
+        );
+      }
+      responses.push(spendSignatureResponse);
+    }
+
+    return responses;
   };
 
   const signLedgerTx = async (
@@ -130,15 +155,20 @@ export const ConfirmSignLedgerTx: React.FC<Props> = ({ details }) => {
       ledger: Ledger,
       tx: string,
       zip32Path: string,
-      signatures: string[]
+      signatures: string[],
+      shieldedHash?: string
     ) => {
-      const { sbar, rbar } = await signMaspTx(
+      const responses = await signMaspTx(
         ledger,
         fromBase64(tx),
-        zip32Path
+        zip32Path,
+        shieldedHash
       );
-      const signature = toBase64(new Uint8Array([...rbar, ...sbar]));
-      signatures.push(signature);
+
+      responses.forEach(({ sbar, rbar }) => {
+        const signature = toBase64(new Uint8Array([...rbar, ...sbar]));
+        signatures.push(signature);
+      });
     },
     []
   );
@@ -197,10 +227,12 @@ export const ConfirmSignLedgerTx: React.FC<Props> = ({ details }) => {
         if (!accountDetails) {
           throw new Error(`Failed to query account details for ${signer}`);
         }
+        const [transparentAccount, shieldedAccount] = accountDetails;
+
         const path = {
-          account: accountDetails.path.account,
-          change: accountDetails.path.change || 0,
-          index: accountDetails.path.index || 0,
+          account: transparentAccount.path.account,
+          change: transparentAccount.path.change || 0,
+          index: transparentAccount.path.index || 0,
         };
 
         const pendingTxs = await requester.sendMessage(
@@ -247,7 +279,7 @@ export const ConfirmSignLedgerTx: React.FC<Props> = ({ details }) => {
           transferTypes.includes("Unshielding") ||
           transferTypes.includes("IbcUnshieldTransfer");
 
-        for await (const tx of pendingTxs) {
+        for await (const { tx, shieldedHash } of pendingTxs) {
           if (txCount > 1) {
             setStepTwoDescription(
               <p>
@@ -259,11 +291,22 @@ export const ConfirmSignLedgerTx: React.FC<Props> = ({ details }) => {
           }
 
           if (fromMasp) {
+            if (!shieldedAccount) {
+              throw new Error(
+                `Shielded account details for ${signer} not found!`
+              );
+            }
             const zip32Path = makeSaplingPath(chains.namada.bip44.coinType, {
-              account: path.account,
+              account: shieldedAccount.path.account,
             });
             // Adds new signature to the collection
-            await handleMaspSignTx(ledger, tx, zip32Path, maspSignatures);
+            await handleMaspSignTx(
+              ledger,
+              tx,
+              zip32Path,
+              maspSignatures,
+              shieldedHash
+            );
           } else {
             const bip44Path = makeBip44Path(chains.namada.bip44.coinType, path);
             // Adds new signature to the collection