Pedantic integer math changes. Explicit uint16_t cast, fix "color-1". #208

SmittyHalibut · SmittyHalibut · commit b48c70c23386 · 2025-02-04T10:01:40.000-08:00
diff --git a/microcontroller-src/kv4p_ht_esp32_wroom_32/kv4p_ht_esp32_wroom_32.ino b/microcontroller-src/kv4p_ht_esp32_wroom_32/kv4p_ht_esp32_wroom_32.ino
@@ -903,9 +903,9 @@ void measureLoopFrequency() {
 }
 
 void neopixelColor(RGBColor C, uint8_t bright = 255) {
-  uint8_t red = (C.red * bright) >> 8;
-  uint8_t green = (C.green * bright) >> 8;
-  uint8_t blue = (C.blue * bright) >> 8;
+  uint8_t red = (uint16_t(C.red) * bright) / 255;
+  uint8_t green = (uint16_t(C.green) * bright) / 255;
+  uint8_t blue = (uint16_t(C.blue) * bright) / 255;
   neopixelWrite(PIXELS_PIN, red, green, blue);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -903,9 +903,9 @@ void measureLoopFrequency() {`
`903`	`903`	`}`
`904`	`904`
`905`	`905`	`void neopixelColor(RGBColor C, uint8_t bright = 255) {`
`906`		`- uint8_t red = (C.red * bright) >> 8;`
`907`		`- uint8_t green = (C.green * bright) >> 8;`
`908`		`- uint8_t blue = (C.blue * bright) >> 8;`
	`906`	`+ uint8_t red = (uint16_t(C.red) * bright) / 255;`
	`907`	`+ uint8_t green = (uint16_t(C.green) * bright) / 255;`
	`908`	`+ uint8_t blue = (uint16_t(C.blue) * bright) / 255;`
`909`	`909`	`neopixelWrite(PIXELS_PIN, red, green, blue);`
`910`	`910`	`}`
`911`	`911`