Skip to content

Commit 6f1d248

Browse files
committed
UPSTREAM<carry>: fix to use runtime CA cert path for MLflow config in API server
Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> (cherry picked from commit c80123e)
1 parent c3934ce commit 6f1d248

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

backend/src/apiserver/plugins/mlflow/handler.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323

2424
"github.com/golang/glog"
2525
apiv2beta1 "github.com/kubeflow/pipelines/backend/api/v2beta1/go_client"
26+
"github.com/kubeflow/pipelines/backend/src/apiserver/common"
2627
apiserverPlugins "github.com/kubeflow/pipelines/backend/src/apiserver/plugins"
2728
commonplugins "github.com/kubeflow/pipelines/backend/src/common/plugins"
2829
commonmlflow "github.com/kubeflow/pipelines/backend/src/common/plugins/mlflow"
@@ -125,7 +126,7 @@ func (h *Handler) OnBeforeRunCreation(ctx context.Context, run *apiserverPlugins
125126
var runtimeTLS *commonplugins.TLSConfig
126127
if runCfg.TLS != nil && runCfg.TLS.CABundlePath != "" {
127128
runtimeTLS = &commonplugins.TLSConfig{
128-
CABundlePath: runCfg.TLS.CABundlePath,
129+
CABundlePath: common.CustomCaCertPath,
129130
}
130131
}
131132
mlflowRuntimeConfig := commonmlflow.MLflowRuntimeConfig{

backend/src/apiserver/plugins/mlflow/handler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ func TestOnBeforeRunCreation_CABundlePath_Propagated(t *testing.T) {
238238
var rtCfg commonmlflow.MLflowRuntimeConfig
239239
require.NoError(t, json.Unmarshal([]byte(env[commonmlflow.EnvMLflowConfig]), &rtCfg))
240240
require.NotNil(t, rtCfg.TLS)
241-
assert.Equal(t, caBundlePath, rtCfg.TLS.CABundlePath)
241+
assert.Equal(t, common.CustomCaCertPath, rtCfg.TLS.CABundlePath)
242242
assert.False(t, rtCfg.TLS.InsecureSkipVerify)
243243
}
244244

0 commit comments

Comments
 (0)