refactor: code quality cleanup — dead code, boilerplate, types, constants, AI comments

- Remove dead code: resumeTimer (no-op), onSwipeGesture (ignores callback),
  themePreset from useAppStore (duplicated), prevNotesRef (unused)
- Consolidate boilerplate: booleanSetter helper in useAppStore, onEvent helper
  in api.ts, data-driven KeybindsModal, removed 11 redundant setters
- Fix Rust: clippy needless_borrows_for_generic_args, unexpected_cfgs lint
- Improve types: GraphControls interface, typed openAIChat response
- Extract ~25 magic numbers to named constants
- Remove ~15 pedagogical AI-style comments

Author: VariableThe

package-lock.json

@@ -32,3 +32,6 @@ tauri-plugin-notification = "2.0.0-rc.5"
 [target.'cfg(target_os = "macos")'.dependencies]
 cocoa = "0.25"
 objc = "0.2"
+
+[lints.rust]
+unexpected_cfgs = "allow"

src-tauri/Cargo.lock

@@ -103,7 +103,7 @@ pub async fn schedule_timer(
             .notification()
             .builder()
             .title("PaperCache Timer")
-            .body(&format!("⏱ Timer finished: {}", label))
+            .body(format!("⏱ Timer finished: {}", label))
             .show();
         let _ = app_clone.emit("timer-complete", &id_clone);
     });

src-tauri/Cargo.toml

@@ -7,6 +7,11 @@ mod commands;
 mod macos;
 mod tray;
 
+#[allow(dead_code)]
+const FOCUS_LOSS_DEBOUNCE_MS: u64 = 200;
+#[allow(dead_code)]
+const WINDOW_STATE_RESTORE_DELAY_MS: u64 = 300;
+
 
 use commands::shortcuts::GlobalShortcutState;
 use commands::notifications::NotificationState;
@@ -87,7 +92,7 @@ pub fn run() {
                                     let dialog_open = is_dialog_open.clone();
                                     std::thread::spawn(move || {
                                         std::thread::sleep(
-                                            std::time::Duration::from_millis(200),
+                                            std::time::Duration::from_millis(FOCUS_LOSS_DEBOUNCE_MS),
                                         );
                                         if g2.load(Ordering::SeqCst) == gen_at_spawn
                                             && !dialog_open.load(Ordering::SeqCst)
@@ -109,7 +114,7 @@ pub fn run() {
                 // Plugin's on_window_ready fires too early for available_monitors() on macOS.
                 let win = window.clone();
                 std::thread::spawn(move || {
-                    std::thread::sleep(std::time::Duration::from_millis(300));
+                    std::thread::sleep(std::time::Duration::from_millis(WINDOW_STATE_RESTORE_DELAY_MS));
                     let _ = win.clone().run_on_main_thread(move || {
                         let _ = win.restore_state(StateFlags::POSITION | StateFlags::SIZE);
                         if let Ok(app_dir) = win.app_handle().path().app_config_dir() {

src-tauri/src/commands/notifications.rs

@@ -23,6 +23,12 @@ import { NoteTitleBar } from './components/NoteTitleBar'
 import { Editor, type EditorRef } from './components/Editor'
 import Settings from './Settings'
 
+const TOAST_TIMEOUT_MS = 5000
+const FOCUS_DELAY_MS = 50
+const MODAL_Z_INDEX = 9999
+const KEYBINDS_Z_INDEX = 10000
+const TOAST_Z_INDEX = 99999
+
 function App() {
   const notes = useAppStore((state) => state.notes)
   const setNotes = useAppStore((state) => state.setNotes)
@@ -50,7 +56,6 @@ function App() {
 
   const searchInputRef = useRef<HTMLInputElement>(null)
 
-  // Custom Hooks
   useNoteStorage()
   useVariables()
   useReminders()
@@ -63,7 +68,6 @@ function App() {
       useAppStore.getState().setIsHyprland(isHyp)
     })
 
-    // Show a toast before the app auto-restarts for an update
     const disposeUpdateReady = window.electronAPI.onUpdateReady(() => {
       useAppStore.getState().addToast({
         message: '✨ PaperCache updated — restarting in 3 seconds…',
@@ -94,26 +98,23 @@ function App() {
     }
   }, [])
 
-  // Auto-dismiss toasts after 5 seconds
   const toastTimersRef = useRef<Map<string, ReturnType<typeof setTimeout>>>(new Map())
   useEffect(() => {
     const timers = toastTimersRef.current
     const currentIds = new Set(toasts.map((t) => t.id))
 
-    // Clear timers for removed toasts
     for (const [id, timer] of timers) {
       if (!currentIds.has(id)) {
         clearTimeout(timer)
         timers.delete(id)
       }
     }
 
-    // Set timers for new toasts
     for (const toast of toasts) {
       if (!timers.has(toast.id)) {
         timers.set(
           toast.id,
-          setTimeout(() => removeToast(toast.id), 5000)
+          setTimeout(() => removeToast(toast.id), TOAST_TIMEOUT_MS)
         )
       }
     }
@@ -123,7 +124,7 @@ function App() {
     if (showNoteSearch && searchInputRef.current) {
       setTimeout(() => {
         searchInputRef.current?.focus()
-      }, 50)
+      }, FOCUS_DELAY_MS)
     }
   }, [showNoteSearch])
 
@@ -205,13 +206,11 @@ function App() {
             const note = currentNotes[idx]
             const newContent = note.content.slice(0, from) + insert + note.content.slice(to)
 
-            // Side-effects outside of state updater
             window.electronAPI.saveNote(note.id, newContent)
             if (idx === currentNoteIndex) {
               editorRef.current?.dispatch({ changes: { from, to, insert } })
             }
 
-            // Pure state update
             setNotes((prevNotes) =>
               prevNotes.map((n) => (n.id === noteId ? { ...n, content: newContent } : n))
             )
@@ -257,7 +256,7 @@ function App() {
             bottom: 0,
             backgroundColor: 'rgba(0, 0, 0, 0.75)',
             backdropFilter: 'blur(5px)',
-            zIndex: 9999,
+            zIndex: MODAL_Z_INDEX,
             overflow: 'auto',
           }}
         >
@@ -276,7 +275,7 @@ function App() {
             bottom: 0,
             backgroundColor: 'rgba(0, 0, 0, 0.75)',
             backdropFilter: 'blur(5px)',
-            zIndex: 10000,
+            zIndex: KEYBINDS_Z_INDEX,
             overflow: 'auto',
           }}
         >
@@ -294,7 +293,7 @@ function App() {
             display: 'flex',
             flexDirection: 'column',
             gap: 8,
-            zIndex: 99999,
+            zIndex: TOAST_Z_INDEX,
           }}
         >
           {toasts.map((toast) => (