Merge pull request #380 from eosnetworkfoundation/yarkin/merge_2.0_exit_on_failure

[2.0->main] Exit instead of silently continue for exceptions when processing blocks

Author: yarkinwho

external/silkworm

@@ -78,8 +78,8 @@ class blockchain_plugin_impl : std::enable_shared_from_this<blockchain_plugin_im
       }
 
       void shutdown() {
-         exec_engine->close();
          exec_engine->stop();
+         exec_engine->close();      
       }
 
       using txn_t = std::unique_ptr<silkworm::db::RWTxn>;

src/blockchain_plugin.cpp

@@ -41,7 +41,26 @@ namespace channels {
       std::optional<native_action>  new_config = std::nullopt;
       std::vector<native_trx> transactions;
    };
+
+   // Dispatch Policy that exit on exception
+   struct exit_on_exceptions {
+      exit_on_exceptions() = default;
+      using result_type = void;
+
+      template<typename InputIterator>
+      result_type operator()(InputIterator first, InputIterator last) {
+         while (first != last) {
+            try {
+               *first;
+            } catch (...) {
+               SILK_CRIT << "Caught exception when processing channel callbacks.";
+               appbase::app().quit();
+            }
+            ++first;
+         }
+      }
+   };
 
-   using native_blocks = appbase::channel_decl<struct native_blocks_tag, std::shared_ptr<native_block>>;
-   using evm_blocks = appbase::channel_decl<struct evm_blocks_tag, std::shared_ptr<silkworm::Block>>;
+   using native_blocks = appbase::channel_decl<struct native_blocks_tag, std::shared_ptr<native_block>, exit_on_exceptions>;
+   using evm_blocks = appbase::channel_decl<struct evm_blocks_tag, std::shared_ptr<silkworm::Block>, exit_on_exceptions>;
 } // ns channels

src/channels.hpp

@@ -124,8 +124,8 @@ class engine_plugin_impl : std::enable_shared_from_this<engine_plugin_impl> {
       }
 
       inline void shutdown() {
-         eth->close();
          server->shutdown();
+         eth->close();
          SILK_INFO << "Stopped Engine Server";
       }