add tests for rust SecretsProvider

Author: rbran

rust/src/secretsprovider.rs

@@ -76,12 +76,12 @@ impl SecretsProvider {
     }
 
     /// Retrieve data for the given key, if it exists
-    pub fn get_data<S: BnStrCompatible>(&self, key: S) -> Option<BnString> {
+    pub fn get_data<S: BnStrCompatible>(&self, key: S) -> BnString {
         let key = key.into_bytes_with_nul();
         let result = unsafe {
             BNGetSecretsProviderData(self.as_raw(), key.as_ref().as_ptr() as *const ffi::c_char)
         };
-        (!result.is_null()).then(|| unsafe { BnString::from_raw(result) })
+        unsafe { BnString::from_raw(result) }
     }
 
     /// Store data with the given key

rust/tests/secretsprovider.rs

@@ -0,0 +1,42 @@
+use binaryninja::headless::Session;
+use binaryninja::secretsprovider::{SecretsProvider, SecretsProviderCallback};
+use rstest::*;
+
+#[fixture]
+fn session() -> Session {
+    Session::new().expect("Failed to initialize session")
+}
+
+#[rstest]
+fn list_secrets_provider(_session: Session) {
+    let providers = SecretsProvider::all();
+    for _provider in &providers {}
+}
+
+struct MySecretsProvider {}
+
+impl SecretsProviderCallback for MySecretsProvider {
+    fn has_data(&mut self, key: &str) -> bool {
+        key == "my_key"
+    }
+
+    fn get_data(&mut self, key: &str) -> String {
+        if key == "my_key" { "my_value" } else { "" }.to_string()
+    }
+
+    fn store_data(&mut self, _key: &str, _data: &str) -> bool {
+        false
+    }
+
+    fn delete_data(&mut self, _key: &str) -> bool {
+        false
+    }
+}
+
+#[rstest]
+fn custom_secrets_provider(_session: Session) {
+    let my_provider = SecretsProvider::new("MySecretsProvider", MySecretsProvider {});
+    assert!(my_provider.has_data("my_key"));
+    assert!(!my_provider.has_data("not_my_key"));
+    assert_eq!(my_provider.get_data("my_key").as_str(), "my_value");
+}