test(reformat): add and fix tests

Author: nullifysecurity

services/repository/fixtures/TestReformat.golden

@@ -23,14 +23,16 @@
   "- query: SELECT * FROM info()",
   "- query: |",
   "    SELECT A",
-  "    FROM scope()"
+  "    FROM scope()",
+  ""
  ],
  "export reformatted": [
   "",
   "name: Exported",
   "export: |",
   "  SELECT *",
-  "  FROM scope()"
+  "  FROM scope()",
+  ""
  ],
  "preconditions": [
   "",
@@ -39,6 +41,37 @@
   "sources:",
   "- precondition: |",
   "    SELECT *",
-  "    FROM info()"
+  "    FROM info()",
+  ""
+ ],
+ "notebook": [
+  "",
+  "name: Notebook",
+  "sources:",
+  "- query: |",
+  "    SELECT A,",
+  "           B,",
+  "           C",
+  "    FROM scope()",
+  "  notebook:",
+  "    - name: Test",
+  "      type: vql_suggestion",
+  "      template: |",
+  "        SELECT * FROM scope()",
+  ""
+ ],
+ "column types": [
+  "",
+  "name: Column Types",
+  "sources:",
+  "- query: |",
+  "    SELECT A,",
+  "           B,",
+  "           C",
+  "    FROM scope()",
+  "column_types:",
+  "  - name: A",
+  "    type: string",
+  ""
  ]
 }

services/repository/reformat_test.go

@@ -47,6 +47,30 @@ precondition: SELECT * FROM info()
 sources:
 - precondition: |
    SELECT * FROM info()
+`}, {
+		name: "notebook",
+		in: `
+name: Notebook
+sources:
+- query: |
+    SELECT A,B,C
+    FROM scope()
+  notebook:
+    - name: Test
+      type: vql_suggestion
+      template: |
+        SELECT * FROM scope()
+`}, {
+		name: "column types",
+		in: `
+name: Column Types
+sources:
+- query: |
+    SELECT A,B,C
+    FROM scope()
+column_types:
+  - name: A
+    type: string
 `},
 }
 
@@ -59,3 +83,15 @@ func TestReformat(t *testing.T) {
 	}
 	goldie.AssertJson(t, "TestReformat", golden)
 }
+
+// Test that when VQL is reformatted multiple times it doesn't change.
+func TestReformatMultiple(t *testing.T) {
+	golden := ordereddict.NewDict()
+	for _, c := range reformatCases {
+		first, err := reformatVQL(c.in)
+		second, err := reformatVQL(first)
+		assert.NoError(t, err)
+		golden.Set(c.name, strings.Split(second, "\n"))
+	}
+	goldie.AssertJson(t, "TestReformat", golden)
+}