Merge pull request #18 from Vendic/bugfix/cached-status-resolver-older-php-syntax

petro-prots · web-flow · commit a9f87fe2a748 · 2025-06-02T15:09:37.000+03:00
Made fallback status enum value retrieval compatible
diff --git a/Model/CachedStatusResolver.php b/Model/CachedStatusResolver.php
@@ -163,14 +163,14 @@ public function setMessagesByStatus(array $messagesByStatus): self
 
     public function getFlappingStatus(string $oldStatus, string $newStatus): CheckStatus
     {
-        $statusToSet = CheckStatus::STATUS_OK;
+        $statusToSet = CheckStatus::STATUS_OK->name;
         if (self::STATUSES_BY_SEVERITY[$oldStatus] < self::STATUSES_BY_SEVERITY[$newStatus]) {
             $statusToSet = "STATUS_" . strtoupper($oldStatus);
         } else {
             $statusToSet = "STATUS_" . strtoupper($newStatus);
         }
 
-        return CheckStatus::{$statusToSet};
+        return constant("\Vendic\OhDear\Api\Data\CheckStatus::{$statusToSet}");
     }
 
     private function getStatusTimeThreshold(): int

Original file line number	Diff line number	Diff line change
`@@ -163,14 +163,14 @@ public function setMessagesByStatus(array $messagesByStatus): self`
`163`	`163`
`164`	`164`	`public function getFlappingStatus(string $oldStatus, string $newStatus): CheckStatus`
`165`	`165`	`{`
`166`		`- $statusToSet = CheckStatus::STATUS_OK;`
	`166`	`+ $statusToSet = CheckStatus::STATUS_OK->name;`
`167`	`167`	`if (self::STATUSES_BY_SEVERITY[$oldStatus] < self::STATUSES_BY_SEVERITY[$newStatus]) {`
`168`	`168`	`$statusToSet = "STATUS_" . strtoupper($oldStatus);`
`169`	`169`	`} else {`
`170`	`170`	`$statusToSet = "STATUS_" . strtoupper($newStatus);`
`171`	`171`	`}`
`172`	`172`
`173`		`- return CheckStatus::{$statusToSet};`
	`173`	`+ return constant("\Vendic\OhDear\Api\Data\CheckStatus::{$statusToSet}");`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`private function getStatusTimeThreshold(): int`