Read settings synchronously

The only await left in SettingsHelper.Read was a 2 byte first run write, and it kept a state machine and a Task on the path that runs at every startup. Read and GetSettings are now sync, and the ReSharper suppression on the ReadAllBytes call goes with them - that inspection only fires inside an async method.

Write stays async: Swap retries File.Move ten times with a 20ms delay, and blocking the UI thread for 200ms while a backup holds the file is the failure it exists to avoid.

Author: SimonCropp

src/DiffEngineTray.Tests/SettingsHelperTests.cs

@@ -63,7 +63,7 @@ await SettingsHelper.Write(
                     AlwaysKillLockingProcesses = true
                 });
 
-            var result = await SettingsHelper.Read();
+            var result = SettingsHelper.Read();
 
             await Verify(result);
         }

src/DiffEngineTray/LockedFilesHandler.cs

@@ -26,7 +26,7 @@ static void Persist() =>
         {
             try
             {
-                var settings = await SettingsHelper.Read();
+                var settings = SettingsHelper.Read();
                 settings.AlwaysKillLockingProcesses = true;
                 await SettingsHelper.Write(settings);
             }

src/DiffEngineTray/Program.cs

@@ -56,7 +56,7 @@ static async Task Inner()
         void Warn(string message) =>
             icon.ShowBalloonTip(10000, "DiffEngineTray", message, ToolTipIcon.Warning);
 
-        var settings = await GetSettings();
+        var settings = GetSettings();
         if (settings == null)
         {
             return;
@@ -181,11 +181,11 @@ internal static IEnumerable<KeyBinding> BuildKeyBindings(Settings settings, Trac
 
     internal record KeyBinding(int Id, HotKey HotKey, Action Action);
 
-    static async Task<Settings?> GetSettings()
+    static Settings? GetSettings()
     {
         try
         {
-            return await SettingsHelper.Read();
+            return SettingsHelper.Read();
         }
         catch (Exception exception)
         {

src/DiffEngineTray/Settings/OptionsFormLauncher.cs

@@ -10,7 +10,7 @@ public static async Task Launch(KeyRegister keyRegister, Tracker tracker)
             return;
         }
 
-        var settings = await SettingsHelper.Read();
+        var settings = SettingsHelper.Read();
         using var form = new OptionsForm(
             settings,
             newSettings => Save(keyRegister, tracker, settings, newSettings));

src/DiffEngineTray/Settings/SettingsHelper.cs

@@ -10,7 +10,7 @@ static SettingsHelper()
         FilePath = Path.Combine(directory, "settings.json");
     }
 
-    public static async Task<Settings> Read()
+    public static Settings Read()
     {
         Settings settings;
         if (File.Exists(FilePath))
@@ -25,7 +25,7 @@ public static async Task<Settings> Read()
         }
         else
         {
-            await File.WriteAllTextAsync(FilePath, "{}");
+            File.WriteAllText(FilePath, "{}");
             settings = new();
         }