Commit 86d0832
committed
Guard TUnit parameter binding and null TestContext
Two fixes in the same method, sharing one helper.
TestMethodArguments holds the raw pre-binding arguments: TUnit bundles a params
array at invocation time. SetParameters was called with them unconditionally, so
a [Arguments(1, 2, 3)] test with a params int[] parameter ran fine under TUnit
but threw 'The number of passed in parameters (3) must not exceed the number of
parameters for the method (1)' from every Verify call. The argument count is now
compared with the parameter name count first, matching MSTest and XunitV3.
TestContext.Current is nullable, and is null in a [Before(TestSession)] hook or
any code that does not flow the test context. Both BuildVerifier and
VerifyChecks.Run dereferenced it with !, giving a bare NullReferenceException.
They now throw the same kind of explanatory error the other adapters do.1 parent d731cfb commit 86d0832
4 files changed
Lines changed: 38 additions & 5 deletions
File tree
- src
- Verify.TUnit.Tests
- Verify.TUnit
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
23 | 37 | | |
24 | 38 | | |
25 | 39 | | |
| |||
28 | 42 | | |
29 | 43 | | |
30 | 44 | | |
31 | | - | |
| 45 | + | |
32 | 46 | | |
33 | 47 | | |
34 | 48 | | |
| 49 | + | |
35 | 50 | | |
36 | 51 | | |
37 | 52 | | |
38 | 53 | | |
39 | | - | |
40 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
41 | 63 | | |
42 | 64 | | |
43 | 65 | | |
| |||
49 | 71 | | |
50 | 72 | | |
51 | 73 | | |
52 | | - | |
| 74 | + | |
53 | 75 | | |
54 | 76 | | |
55 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
0 commit comments