Skip to content

Makefile's test/check targets don't match CI's --workspace invocation #220

Description

@N-i-xx

Problem

The Makefile's test/check targets run plain cargo test/cargo check with no --workspace flag, while .github/workflows/ci.yml explicitly runs cargo build --workspace and cargo test --workspace.

Why it matters

Running make test/make check locally doesn't necessarily exercise the verification workspace member the same way CI does, so a contributor getting a clean local run has no guarantee CI will also pass — the two entry points to "run the tests" aren't equivalent.

Suggested fix

Add --workspace to the relevant Makefile targets so local runs match CI's scope.

Acceptance criteria

  • make test and make check invoke cargo with --workspace, matching CI
  • make test and make check both succeed locally after the change

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions