Validate the Horizon URL, encode the public key, and add a timeout in AccountLoader.fetchAccount

[N-thnI]

Description

Bring account loading up to the endpoint-safety standard the rest of the SDK enforces.

Problem Statement

src/account/loader.ts:79-98 does const url = \${horizonUrl}/accounts/${publicKey}`; const response = await fetch(url);`

This bypasses validateUrl from src/network/index.ts entirely — the module whose header documents exactly this failure (a plaintext or hostile endpoint misreporting on-chain state, vero-guardian-dashboard#288).

publicKey is interpolated unencoded, so a caller-supplied value containing ../ or ?/# redirects the request to a different Horizon resource. There is no AbortSignal, so a non-responding Horizon hangs the caller indefinitely.

The catch on lines 92-97 also flattens every failure into new Error(...), discarding status codes and defeating the SDK's own VeroError/normalizeError contract.

Proposed Changes

• Call validateUrl(horizonUrl, opts) before building the request
• Use new URL(\accounts/${encodeURIComponent(publicKey)}`, base)and assert the resulting origin matches, mirroringsrc/rpc/index.ts:125-131`
• Pass an AbortController signal with a configurable timeout
• Throw VeroError with AccountNotFound / RpcRequestFailed codes via normalizeError instead of a bare Error

Technical Implementation Scaffolding

• Target Repository: vero-sdk
• Target Path: src/account/loader.ts
• Branch Naming: fix/issue--account-loader-url-safety
• Authority Context: Security-sensitive — endpoint validation bypass

Acceptance Criteria

• loadAccount('http://evil.example', ...) throws VeroError with code INVALID_URL
• A publicKey of ../ledgers/1 does not produce a request outside /accounts/
• A stubbed fetch that never resolves causes loadAccount to reject within the timeout
• A 404 rejects with VeroErrorCode.AccountNotFound

Definition of Done

• Reviewed by lead maintainer
• Pull request merged via verified status check

[Neziahtech]

Hello,

I’d love to take this issue on. I’m a full-stack developer with experience across Drips Waves 3–7, and the GrantFox oficiall 1 and2 campaign.

My stack includes Rust, Soroban, Solidity, and TypeScript. I can deliver a clean, tested, and well-documented solution within 24 hours of assignment.

Happy to start immediately.

[gloskull]

Hi, I’d love to work on this issue. I have 4 years of experience across backend, frontend, full-stack, and smart contract development. I understand the task clearly and can deliver a clean, efficient, well-tested solution on time, with strong focus on code quality and maintainability. My PR will be submitted in 8hours.

[grantfox-oss]

🦊 GrantFox — @gloskull has been assigned to this issue as part of the Third Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #68)
2. Your PR will be reviewed by the Vero-protocol maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!

@gloskull's PR #82 was approved and merged by @N-i-xx.

🏆 @gloskull: You earned 50 FoxPoints for this contribution! Your current tier: Pro (10,028 total points). Track your full progress on GrantFox.

👏 Great work, @gloskull! Keep contributing to Vero-protocol.