Skip to content

Commit bdc79c4

Browse files
committed
Remove unmapped piston warning
Remove some wont-fix/unneeded todos
1 parent f83ac57 commit bdc79c4

File tree

6 files changed

+5
-7
lines changed

6 files changed

+5
-7
lines changed

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_10to1_11/packets/BlockItemPackets1_11.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public void handle(PacketWrapper wrapper) throws Exception {
192192

193193
handleChunk(chunk);
194194

195-
// only patch it for signs for now, TODO-> Find all the block entities old/new to replace ids and implement in ViaVersion
195+
// only patch it for signs for now
196196
for (CompoundTag tag : chunk.getBlockEntities()) {
197197
Tag idTag = tag.get("id");
198198
if (!(idTag instanceof StringTag)) continue;

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_11_1to1_12/packets/BlockItemPackets1_12.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ public void registerMap() {
239239
public void handle(PacketWrapper wrapper) throws Exception {
240240
// Open Inventory
241241
if (wrapper.get(Type.VAR_INT, 0) == 2) {
242-
wrapper.cancel(); // TODO is this replaced by something else?
242+
wrapper.cancel();
243243
}
244244
}
245245
});

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/Protocol1_12_2To1_13.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected void handleTranslate(JsonObject root, String translate) {
7878
cancelOutgoing(ClientboundPackets1_13.CRAFT_RECIPE_RESPONSE);
7979
cancelOutgoing(ClientboundPackets1_13.UNLOCK_RECIPES);
8080
cancelOutgoing(ClientboundPackets1_13.ADVANCEMENTS);
81-
cancelOutgoing(ClientboundPackets1_13.DECLARE_RECIPES); //TODO ?
81+
cancelOutgoing(ClientboundPackets1_13.DECLARE_RECIPES);
8282
cancelOutgoing(ClientboundPackets1_13.TAGS);
8383

8484
cancelIncoming(ServerboundPackets1_12_1.CRAFT_RECIPE_REQUEST);

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/block_entity_handlers/PistonHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package nl.matsv.viabackwards.protocol.protocol1_12_2to1_13.block_entity_handlers;
22

3-
import nl.matsv.viabackwards.ViaBackwards;
43
import nl.matsv.viabackwards.protocol.protocol1_12_2to1_13.data.BackwardsMappings;
54
import nl.matsv.viabackwards.protocol.protocol1_12_2to1_13.providers.BackwardsBlockEntityProvider;
65
import us.myles.ViaVersion.api.Via;
@@ -74,7 +73,7 @@ public CompoundTag transform(UserConnection user, int blockId, CompoundTag tag)
7473

7574
Integer id = pistonIds.get(dataFromTag);
7675
if (id == null) {
77-
ViaBackwards.getPlatform().getLogger().warning("Unmapped piston id: " + dataFromTag);
76+
//TODO see why this could be null and if this is bad
7877
return tag;
7978
}
8079

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_12_2to1_13/packets/PlayerPacket1_13.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ public void handle(PacketWrapper wrapper) throws Exception {
513513
int statisticId = wrapper.read(Type.VAR_INT);
514514

515515
String name = "";
516-
//TODO categories 0-7 (items, blocks, entities) - probably not feasible
516+
// categories 0-7 (items, blocks, entities) - probably not feasible
517517
switch (categoryId) {
518518
case 0:
519519
case 1:

core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_13_2to1_14/packets/EntityPackets1_14.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,6 @@ protected void registerRewrites() {
381381
if (type.isOrHasParent(Entity1_14Types.EntityType.ABSTRACT_ILLAGER_BASE) || type == Entity1_14Types.EntityType.RAVAGER || type == Entity1_14Types.EntityType.WITCH) {
382382
int index = e.getIndex();
383383
if (index == 14) {
384-
//TODO handle
385384
throw RemovedValueException.EX;
386385
} else if (index > 14) {
387386
meta.setId(index - 1);

0 commit comments

Comments
 (0)