Fix effects value

kennytv · kennytv · commit e325a03c0a7d · 2020-08-10T22:03:05.000+02:00
diff --git a/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_16_1to1_16_2/packets/EntityPackets1_16_2.java b/core/src/main/java/nl/matsv/viabackwards/protocol/protocol1_16_1to1_16_2/packets/EntityPackets1_16_2.java
@@ -84,8 +84,9 @@ public void registerMap() {
     }
 
     private String getDimensionFromData(CompoundTag dimensionData) {
+        // This may technically break other custom dimension settings for 1.16/1.16.1 clients, so those cases are considered semi "unsupported" here
         StringTag effectsLocation = dimensionData.get("effects");
-        return effectsLocation != null && oldDimensions.contains(effectsLocation.getValue()) ? effectsLocation.getName() : "minecraft:overworld";
+        return effectsLocation != null && oldDimensions.contains(effectsLocation.getValue()) ? effectsLocation.getValue() : "minecraft:overworld";
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,9 @@ public void registerMap() {`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`private String getDimensionFromData(CompoundTag dimensionData) {`
	`87`	`+ // This may technically break other custom dimension settings for 1.16/1.16.1 clients, so those cases are considered semi "unsupported" here`
`87`	`88`	`StringTag effectsLocation = dimensionData.get("effects");`
`88`		`- return effectsLocation != null && oldDimensions.contains(effectsLocation.getValue()) ? effectsLocation.getName() : "minecraft:overworld";`
	`89`	`+ return effectsLocation != null && oldDimensions.contains(effectsLocation.getValue()) ? effectsLocation.getValue() : "minecraft:overworld";`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`@Override`