High allocation rate due to component serialization errors #1181
Description
'/viaversion dump' Output
https://dump.viaversion.com/8189b6eb783d12e64c799f9a33838a3fc4037d413ee548343aab1ef3c1a8c31c
Server/Client Error
https://mclo.gs/HnT40dE
added debug into mcstruct for myself, you cannot see this with a normal via build
Bug Description
When you join 1.21.8 server from a version lower (for example 1.20.4 or 1.16.5, the version I've tested) viabackwards (or rather viaversion?) can start generating an incredible number of serialization errors that lead to an incredibly high memory consumption. Whenever the server sends a component, it will generate an error.
Spark report:
https://spark.lucko.me/Wfa5kUXiNx?hl=1884
Steps to Reproduce
- Install paper/purpur 1.21.8 with via plugins
- Install TAB plugin (the easiest way, since it sends a lot of components if you are using animations)
- Use these configs: https://mega.nz/file/l75DjZ4Q#zz84WsP-Uj1DZqsV2jyc6G9u27nmsyroFBv1tfDe5tI
3.5) If you think this only can be caused by TAB - it is not. As I said earlier anything that can send components cause this error. - Join with 1.20.4 or 1.16.5 and run
spark profiler start --interval 65536 --timeout 300 --thread * --alloc - Open the profiler result and look for
Result.mergeErrors()
Additional Server Info
None (just a regular paper server)
Checklist
- Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
- I have included a ViaVersion dump.
- If applicable, I have included a paste (not a screenshot) of the error.
- I have tried a build from https://ci.viaversion.com/ and the issue still persists.