app/vlinsert/opentelemetry: skip attributes with missing key

While such attributes have no sense, it has been appeared that they can be sent by OTEL collector.
See #869 (comment)

Author: valyala

app/vlinsert/opentelemetry/opentelemetry_test.go

@@ -100,6 +100,8 @@ func TestPushProtobufRequest(t *testing.T) {
 			"attributes": [
 				{"key":"logger","value":{"stringValue":"context"}},
 				{"key":"instance_id","value":{"intValue":10}},
+				{"key":"","value":{"stringValue":"missing-key"}},
+				{"key":"missing-value","value":{"stringValue":""}},
 				{"key":"node_taints","value":{"keyValueList":{"values":
 					[{"key":"role","value":{"stringValue":"dev"}},{"key":"cluster_load_percent","value":{"doubleValue":0.55}}]
 				}}}
@@ -418,7 +420,9 @@ type keyValue struct {
 }
 
 func (kv *keyValue) marshalProtobuf(mm *easyproto.MessageMarshaler) {
-	mm.AppendString(1, kv.Key)
+	if kv.Key != "" {
+		mm.AppendString(1, kv.Key)
+	}
 	if kv.Value != nil {
 		kv.Value.marshalProtobuf(mm.AppendMessage(2))
 	}

app/vlinsert/opentelemetry/pb.go

@@ -359,7 +359,9 @@ func decodeKeyValue(src []byte, fs *logstorage.Fields, fb *fmtBuffer, fieldNameP
 		return fmt.Errorf("cannot find Key in KeyValue: %w", err)
 	}
 	if !ok {
-		return fmt.Errorf("key is missing in KeyValue")
+		// Key is missing, skip it.
+		// See https://github.com/VictoriaMetrics/VictoriaLogs/issues/869#issuecomment-3631307996
+		return nil
 	}
 	fieldName := fb.formatSubFieldName(fieldNamePrefix, key)
 

app/vlinsert/opentelemetry/pb_json.go

@@ -169,7 +169,9 @@ func decodeKeyValueToJSON(src []byte, dst *fastjson.Value, a *fastjson.Arena, fb
 		return fmt.Errorf("cannot find Key in KeyValue: %w", err)
 	}
 	if !ok {
-		return fmt.Errorf("key is missing in KeyValue")
+		// Key is missing, skip it.
+		// See https://github.com/VictoriaMetrics/VictoriaLogs/issues/869#issuecomment-3631307996
+		return nil
 	}
 
 	// Decode value

docs/victorialogs/CHANGELOG.md

@@ -23,7 +23,8 @@ according to the follosing docs:
 
 * FEATURE: [OpenTelemetry data ingestion](https://docs.victoriametrics.com/victorialogs/data-ingestion/opentelemetry/): parse [`scope` inside ScopeLogs](https://github.com/open-telemetry/opentelemetry-proto/blob/a5f0eac5b802f7ae51dfe41e5116fe5548955e64/opentelemetry/proto/logs/v1/logs.proto#L72) and store it into [log fields](https://docs.victoriametrics.com/victorialogs/keyconcepts/#data-model) starting with `scope.` prefix. See [#826](https://github.com/VictoriaMetrics/VictoriaLogs/issues/826).
 
-* BUGFIX: [OpenTelemetry data ingestion](https://docs.victoriametrics.com/victorialogs/data-ingestion/opentelemetry/): properly handle `null` values inside arrays. Previously, such arrays could cause a panic during ingestion. See [#869](https://github.com/VictoriaMetrics/VictoriaLogs/issues/869#issuecomment-3627177567).
+* BUGFIX: [OpenTelemetry data ingestion](https://docs.victoriametrics.com/victorialogs/data-ingestion/opentelemetry/): properly handle `null` values inside arrays. Previously, such arrays could cause a panic during ingestion. See [#869](https://github.com/VictoriaMetrics/VictoriaLogs/issues/869#issuecomment-3627177567). The issue has been introduced in [v1.40.0](https://github.com/VictoriaMetrics/VictoriaLogs/releases/tag/v1.40.0).
+* BUGFIX: [OpenTelemetry data ingestion](https://docs.victoriametrics.com/victorialogs/data-ingestion/opentelemetry/): properly skip attributes with missing key. See [this report](https://github.com/VictoriaMetrics/VictoriaLogs/issues/869#issuecomment-3631307996).
 
 ## [v1.40.0](https://github.com/VictoriaMetrics/VictoriaLogs/releases/tag/v1.40.0)