Skip to content

Commit 3c664e1

Browse files
committed
small fixes
1 parent a6f8bca commit 3c664e1

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

app/vlselect/internalselect/internalselect.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -501,12 +501,15 @@ func writeValuesWithHits(w http.ResponseWriter, qctx *logstorage.QueryContext, v
501501
return nil
502502
}
503503

504-
func writeTenantIDs(w http.ResponseWriter, tenantIDs []byte, disableCompression bool) error {
504+
func writeTenantIDs(w http.ResponseWriter, tenantIDs []logstorage.TenantID, disableCompression bool) error {
505+
// Marshal tenantIDs at first
506+
var b []byte
507+
logstorage.MarshalTenantIDs(b, tenantIDs)
505508
if !disableCompression {
506-
tenantIDs = zstd.CompressLevel(nil, tenantIDs, 1)
509+
b = zstd.CompressLevel(nil, b, 1)
507510
}
508511
w.Header().Set("Content-Type", "application/json")
509-
if _, err := w.Write(tenantIDs); err != nil {
512+
if _, err := w.Write(b); err != nil {
510513
return fmt.Errorf("cannot send response to the client: %w", err)
511514
}
512515
return nil

app/vlselect/logsql/logsql.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package logsql
22

33
import (
44
"context"
5-
"encoding/json"
65
"flag"
76
"fmt"
87
"io"

app/vlstorage/netselect/netselect.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ func (sn *storageNode) getTenantIDs(ctx context.Context, start, end int64) ([]by
251251
args.Set("start", fmt.Sprintf("%d", start))
252252
args.Set("end", fmt.Sprintf("%d", end))
253253
args.Set("disable_compression", fmt.Sprintf("%v", sn.s.disableCompression))
254-
return sn.executeRequestAt(ctx, "/internal/select/tenant_ids", args)
254+
return sn.getResponseForPathAndArgs(ctx, "/internal/select/tenant_ids", args)
255255
}
256256

257257
func (sn *storageNode) getCommonArgs(version string, qctx *logstorage.QueryContext) url.Values {
@@ -601,7 +601,7 @@ func (s *Storage) getTenantIDs(ctx context.Context, start, end int64) ([]logstor
601601
}(i)
602602
}
603603
wg.Wait()
604-
if err := getFirstNonCancelError(errs); err != nil {
604+
if err := getFirstError(errs, false); err != nil {
605605
return nil, err
606606
}
607607

0 commit comments

Comments
 (0)